blender
/
blender
137
410
Fork 592
Code Issues 6.3k Pull Requests 771 Projects 19 Wiki Activity

I18n: translate missing geometry node attribute tooltips #109384

Merged
Bastien Montagne merged 1 commits from pioverfour/blender:dp_gn_attribute_tooltips into main 2023-07-04 09:53:31 +02:00
Conversation 1 Commits 1 Files Changed 1 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/editors/space_node/node_draw.cc
View File

@ -927,7 +927,7 @@ static void create_inspection_string_for_field_info(const bNodeSocket &socket,
for (const int i : input_tooltips.index_range()) {
const blender::StringRef tooltip = input_tooltips[i];
ss << "\u2022 " << TIP_(tooltip.data());
ss << fmt::format(TIP_("\u2022 {}"), TIP_(tooltip.data()));
if (i < input_tooltips.size() - 1) {
ss << ".\n";
pioverfour marked this conversation as resolved Outdated
Bastien Montagne commented 2023-06-27 18:55:44 +02:00
Outdated
Review
Copy Link

Any reasons not to use fmt::format here?

ss << fmt::format(TIP_("\u2022 {}"), TIP_(tooltip.data()));
Any reasons not to use `fmt::format` here? ``` ss << fmt::format(TIP_("\u2022 {}"), TIP_(tooltip.data())); ```
Damien Picard commented 2023-06-27 19:06:31 +02:00
Outdated
Review
Copy Link

No particular reason except consistency, since the other similar messages use this construction, and I didn’t want to change existing messages and make translators update them. But I could do either if you think it’s better.

No particular reason except consistency, since the other similar messages use this construction, and I didn’t want to change existing messages and make translators update them. But I could do either if you think it’s better.
Bastien Montagne commented 2023-07-03 12:15:18 +02:00
Outdated
Review
Copy Link

Fair enough... But since this is a c++ file now, I'd rather see new code using c++ 'way of doing things'. ;)

No need to change existing ones though, this should be part of cleanup/maintenance work from the module owning this file.

Fair enough... But since this is a c++ file now, I'd rather see new code using c++ 'way of doing things'. ;) No need to change existing ones though, this should be part of cleanup/maintenance work from the module owning this file.
👍 1
}
@ -1920,7 +1920,7 @@ static char *named_attribute_tooltip(bContext * /*C*/, void *argN, const char *
for (const NameWithUsage &attribute : sorted_used_attribute) {
const StringRefNull name = attribute.name;
const geo_log::NamedAttributeUsage usage = attribute.usage;
ss << " \u2022 \"" << name << "\": ";
ss << fmt::format(TIP_(" \u2022 \"{}\": "), std::string_view(name));
Vector<std::string> usages;
if ((usage & geo_log::NamedAttributeUsage::Read) != geo_log::NamedAttributeUsage::None) {
usages.append(TIP_("read"));