Geometry Nodes: Propagate geometry component limitation on group declaration #109394
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#109394
Loading…
Reference in New Issue
No description provided.
Delete Branch "mod_moder/blender:group_declaration_geo_sup"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Function for node groups. When user want to put geometry
to group socket, information about type of components to
support can be added to tooltip by author. This not too
automatic, error-prone and the data may no longer be
up-to-date when the nodes capabilities are expanded.
This PR added automatic mechanism to deduce list of supported
types of geometry component for socket of node group.
Right now list of supported geometry component is not
propagated as field interfacing in a node tree. If a Curve
only socket connected to group input node via some general
node without limitation, this group socket will be marked
as support everything. This too complex task and not solved
in this PR.
Supported components is any component, what can be taken by
at least one socket. So, even if only one socket from all
connected can take Point Cloud, it going be displayed as
supported in node group interface tooltip.
WIP: Geometry Nodes: Propagate geometry component limitation on group declarationto Geometry Nodes: Propagate geometry component limitation on group declarationI think this generally makes sense, but it's probably not complete without propagating the supported types forwards and backwards, and without considering field input nodes. I'm not sure how much it makes sense to add this if it's not "complete," it might be misleading.
@ -134,0 +140,4 @@
const bNodeSocket &output = input_node->output_by_identifier(socket_name);
for (const bNodeSocket *input : output.logically_linked_sockets()) {
const bNode &owner_node = input->owner_node();
bke::nodeDeclarationEnsureOnOutdatedNode(const_cast<bNodeTree *>(&tree),
I don't think it's okay to call this on a const node. Is this actually necessary? The declarations would ideally be up to date already at this point.
Just requesting changes based on my previous comment.
Checkout
From your project repository, check out a new branch and test the changes.