blender
/
blender
134
398
Fork 580
Code Issues 6.3k Pull Requests 754 Projects 19 Wiki Activity

Transform: use transform Pivot for AutoDepth during navigation #109451

Merged
Germano Cavalcante merged 1 commits from mano-wii/blender:transform_navigate_mouse into main 2023-07-31 16:06:43 +02:00
Conversation 17 Commits 1 Files Changed 2 +14 -5
Germano Cavalcante commented 2023-06-28 16:56:19 +02:00
Member
Copy Link

To avoid the small jumps during the Pan operation, a feature was
implemented in the ED_view3d_navigation_do utility that replaces the
point used for AutoDepth.

As a result, the depth of the pivot point is now used during the
transform.

Also, to ensure minimal disruption to non-AutoDepth users, this feature
is enabled only when "Auto Depth" is enabled.

Ref #109434

Build:
https://builder.blender.org/download/patch/PR109451/

To avoid the small jumps during the Pan operation, a feature was implemented in the `ED_view3d_navigation_do` utility that replaces the point used for AutoDepth. As a result, the depth of the pivot point is now used during the transform. Also, to ensure minimal disruption to non-AutoDepth users, this feature is enabled only when "Auto Depth" is enabled. --- Ref #109434 Build: https://builder.blender.org/download/patch/PR109451/
Germano Cavalcante commented 2023-06-28 16:57:05 +02:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2023-06-28 16:57:08 +02:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109451) when ready.
Julien Kaspar commented 2023-06-28 18:12:58 +02:00
Member
Copy Link

I've used it for a bit and it looks like it fixed all issues I've pointed out in #109434 👍
But it would be good if some more people tested it.

I've used it for a bit and it looks like it fixed all issues I've pointed out in #109434 👍 But it would be good if some more people tested it.
Germano Cavalcante force-pushed transform_navigate_mouse from 1cea784c20 to d40e10e344 2023-06-28 20:11:58 +02:00 Compare
Germano Cavalcante commented 2023-06-28 20:15:04 +02:00
Author
Member
Copy Link

When testing I noticed some bugs in the implementation in main.

I fixed this bug with ce7ee791b0 and b6a534e41b.

Only ce7ee791b0 also affects this patch.
I'll keep testing.

@blender-bot package

When testing I noticed some bugs in the implementation in main. I fixed this bug with ce7ee791b0 and b6a534e41b. Only ce7ee791b0 also affects this patch. I'll keep testing. @blender-bot package
Blender Bot commented 2023-06-28 20:15:09 +02:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109451) when ready.
Germano Cavalcante force-pushed transform_navigate_mouse from d40e10e344 to 893fe16d93 2023-06-28 20:25:48 +02:00 Compare
Germano Cavalcante commented 2023-06-28 20:26:25 +02:00
Author
Member
Copy Link

@blender-bot build

@blender-bot build
Sun Kim commented 2023-06-29 06:55:04 +02:00
Contributor
Copy Link

I tried the new build. I have issues with all GRS operations.

Move immediately brings the object to a far away position. (-16711634 m, 4881020 m, -13445089 m) for example. (It seems these numbers change based on the size of viewport. The numbers stay the same if the viewport size stays the same.) Rotate immediately rotates the object some degree along the view axis. Scale immediately scales the object to (0.0, 0.0, 0.0).

These all happen regardless of navigation controls.

I tried the new build. I have issues with all GRS operations. Move immediately brings the object to a far away position. (-16711634 m, 4881020 m, -13445089 m) for example. (It seems these numbers change based on the size of viewport. The numbers stay the same if the viewport size stays the same.) Rotate immediately rotates the object some degree along the view axis. Scale immediately scales the object to (0.0, 0.0, 0.0). These all happen regardless of navigation controls.
Germano Cavalcante force-pushed transform_navigate_mouse from 893fe16d93 to fb81590128 2023-07-04 16:08:25 +02:00 Compare
Germano Cavalcante commented 2023-07-04 16:16:34 +02:00
Author
Member
Copy Link

@persun, thanks for the information and for looking to test.

I still don't have a strong opinion about this change.
For me both approaches are good.
And I can't say which one is more intuitive.

  • Fixed the undefined position issues.

@blender-bot package

@persun, thanks for the information and for looking to test. I still don't have a strong opinion about this change. For me both approaches are good. And I can't say which one is more intuitive. - Fixed the undefined position issues. @blender-bot package
Blender Bot commented 2023-07-04 16:16:39 +02:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109451) when ready.
Germano Cavalcante force-pushed transform_navigate_mouse from fb81590128 to a2586e5dca 2023-07-12 17:54:38 +02:00 Compare
Germano Cavalcante commented 2023-07-12 17:59:10 +02:00
Author
Member
Copy Link

Update:

To avoid small jumps during the Pan operation, a feature was implemented in the ED_view3d_navigation_do utility that overwrites the point used for AutoDepth. So the depth becomes the pivot point of the transformation.

Also, in order not to change the behavior too much for users who don't use AutoDepth, this feature (of using the depth of the pivot point) is only used when the option "Auto Depth" is enabled.

@blender-bot package

Update: To avoid small jumps during the Pan operation, a feature was implemented in the `ED_view3d_navigation_do` utility that overwrites the point used for `AutoDepth`. So the depth becomes the pivot point of the transformation. Also, in order not to change the behavior too much for users who don't use `AutoDepth`, this feature (of using the depth of the pivot point) is only used when the option "Auto Depth" is enabled. @blender-bot package
Blender Bot commented 2023-07-12 17:59:15 +02:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109451) when ready.
Germano Cavalcante commented 2023-07-12 18:36:51 +02:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2023-07-12 18:36:58 +02:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109451) when ready.
Germano Cavalcante force-pushed transform_navigate_mouse from dde1dd023a to d1de05c91b 2023-07-12 20:46:41 +02:00 Compare
Germano Cavalcante commented 2023-07-12 20:51:05 +02:00
Author
Member
Copy Link

For testing, this PR also implements a feature to apply the transform during a navigation.

This removes 100% of the jumps.

But on the other hand, maybe it can be a bit disorienting when Orbiting and Zooming the 3D View.

@blender-bot package

For testing, this PR also implements a feature to apply the transform during a navigation. This removes 100% of the jumps. But on the other hand, maybe it can be a bit disorienting when Orbiting and Zooming the 3D View. @blender-bot package
Blender Bot commented 2023-07-12 20:51:11 +02:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109451) when ready.
Germano Cavalcante changed title from Transform: Navigate: Disable umproject cursor aproach to Transform: Navigation Tests: Auto Depth to Pivot | Screen mouse offset position | Transform during navigation 2023-07-12 20:57:44 +02:00
Germano Cavalcante force-pushed transform_navigate_mouse from d1de05c91b to 36edd6f43e 2023-07-25 16:17:10 +02:00 Compare
Germano Cavalcante commented 2023-07-25 16:21:05 +02:00
Author
Member
Copy Link

I updated the build and removed the feature to update the transform during navigation.

This feature has been moved to !110465

It might help to test the features separately.

@blender-bot package

I updated the build and removed the feature to update the transform during navigation. This feature has been moved to !110465 It might help to test the features separately. @blender-bot package
Blender Bot commented 2023-07-25 16:21:12 +02:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109451) when ready.
Germano Cavalcante requested review from Julien Kaspar 2023-07-25 16:21:20 +02:00
Germano Cavalcante changed title from Transform: Navigation Tests: Auto Depth to Pivot | Screen mouse offset position | Transform during navigation to Transform: Navigation Tests: Auto Depth to Pivot | Screen mouse offset position 2023-07-25 16:21:31 +02:00
Julien Kaspar approved these changes 2023-07-31 14:27:01 +02:00
Julien Kaspar left a comment
Member
Copy Link

Works just like expected with and without Auto Depth enabled.

Works just like expected with and without Auto Depth enabled.
Germano Cavalcante force-pushed transform_navigate_mouse from 36edd6f43e to ebc37c38fd 2023-07-31 16:05:16 +02:00 Compare
Germano Cavalcante changed title from Transform: Navigation Tests: Auto Depth to Pivot | Screen mouse offset position to Transform: use transform Pivot for AutoDepth during navigation 2023-07-31 16:05:36 +02:00
Germano Cavalcante merged commit c6fb80cb9b into main 2023-07-31 16:06:43 +02:00
Germano Cavalcante deleted branch transform_navigate_mouse 2023-07-31 16:06:45 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Julien Kaspar
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#109451
No description provided.
Delete Branch "mano-wii/blender:transform_navigate_mouse"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?