Cycles: improve oneAPI requirements text in the UI #109644

Merged
Xavier Hallade merged 1 commits from xavierh/blender:oneapi_reqs_ui into main 2023-07-05 12:16:10 +02:00
Member

No response

_No response_
Xavier Hallade added 1 commit 2023-07-03 13:41:31 +02:00
Xavier Hallade requested review from Brecht Van Lommel 2023-07-03 13:42:23 +02:00
Xavier Hallade added this to the 4.0 milestone 2023-07-03 13:42:37 +02:00
Xavier Hallade added this to the Render & Cycles project 2023-07-03 13:42:42 +02:00
Member

I just wanted to bring up some points on the Linux side of things.

From my understanding on Linux we need intel-level-zero-gpu for oneAPI to work properly. And for many Linux distrobutions, the intel-level-zero-gpu isn't a stand alone package, but instead bundled with the intel-compute-runtime package. Hence why this Pull Request lists intel-level-zero-gpu or intel-compute-runtime as the requirements.

But this isn't true is it? We don't need intel-level-zero-gpu **OR** intel-compute-runtime, we need intel-level-zero-gpu and intel-compute-runtime is the most common way of obtaining this package on many distributions. But having intel-compute-runtime installed doesn't guarantee that you'll have intel-level-zero-gpu (E.G. Your package maintainer doesn't build the compute runtime with level zero). So it should be clarified that you need intel-level-zero-gpu and intel-compute-runtime is just a common way to get it.

So I think the wording on the Linux side should be changed. I feel like it should say:
Requires Intel GPU with Xe-HPG architecture and intel-level-zero-gpu XX.XX.25812 or newer, typically available through the intel-compute-runtime package XX.XX.25812 or newer

But you may want to wait for review from Brecht on this.

Please correct me if I got anything wrong.


The Windows side looks fine to me.

I just wanted to bring up some points on the Linux side of things. From my understanding on Linux we **need** `intel-level-zero-gpu` for oneAPI to work properly. And for many Linux distrobutions, the `intel-level-zero-gpu` isn't a stand alone package, but instead bundled with the `intel-compute-runtime` package. Hence why this Pull Request lists `intel-level-zero-gpu or intel-compute-runtime` as the requirements. But this isn't true is it? We don't need `intel-level-zero-gpu **OR** intel-compute-runtime`, we need `intel-level-zero-gpu` and `intel-compute-runtime` is the most common way of obtaining this package on many distributions. But having `intel-compute-runtime` installed doesn't guarantee that you'll have `intel-level-zero-gpu` (E.G. Your package maintainer doesn't build the compute runtime with level zero). So it should be clarified that you need `intel-level-zero-gpu` and `intel-compute-runtime` is just a common way to get it. So I think the wording on the Linux side should be changed. I feel like it should say: `Requires Intel GPU with Xe-HPG architecture and intel-level-zero-gpu XX.XX.25812 or newer, typically available through the intel-compute-runtime package XX.XX.25812 or newer` But you may want to wait for review from Brecht on this. Please correct me if I got anything wrong. --- The Windows side looks fine to me.
Author
Member

having intel-compute-runtime installed doesn't guarantee that you'll have intel-level-zero-gpu

I wouldn't say that's true from an end-user perspective. It does guarantee it.*
intel-compute-runtime is the common source that provides the runtime libraries.
If a Linux distribution has intel-compute-runtime, it's expected that it brings everything from it, so OpenCL and Level-Zero runtimes.
If it doesn't have it, then the libraries split across OpenCL and Level-Zero runtime specific packages.
So from a user perspective, you can either find one or the other, not both separately. Unless compute-runtime is a virtual package that includes the split ones, and then it doesn't matter to pick one or the other or both.

*There is still one possible edge case if a maintainer chooses to package the whole compute-runtime but with the Level-Zero part disabled, but then, again there wouldn't be a separate intel-level-zero-gpu package available. I suppose the correct course of action is for the user to open a bug report and it gets fixed at the distribution level - there wouldn't be room in the UI to explain the requirement down to that level of details.

> having intel-compute-runtime installed doesn't guarantee that you'll have intel-level-zero-gpu I wouldn't say that's true from an end-user perspective. It does guarantee it.* intel-compute-runtime is the common source that provides the runtime libraries. If a Linux distribution has intel-compute-runtime, it's expected that it brings everything from it, so OpenCL and Level-Zero runtimes. If it doesn't have it, then the libraries split across OpenCL and Level-Zero runtime specific packages. So from a user perspective, you can either find one or the other, not both separately. Unless compute-runtime is a virtual package that includes the split ones, and then it doesn't matter to pick one or the other or both. *There is still one possible edge case if a maintainer chooses to package the whole compute-runtime but with the Level-Zero part disabled, but then, again there wouldn't be a separate intel-level-zero-gpu package available. I suppose the correct course of action is for the user to open a bug report and it gets fixed at the distribution level - there wouldn't be room in the UI to explain the requirement down to that level of details.
Brecht Van Lommel approved these changes 2023-07-05 12:13:06 +02:00
Xavier Hallade merged commit d55cdb1b7a into main 2023-07-05 12:16:10 +02:00
Xavier Hallade deleted branch oneapi_reqs_ui 2023-07-05 12:16:11 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#109644
No description provided.