blender
/
blender
136
419
Fork 600
Code Issues 6.3k Pull Requests 775 Projects 19 Wiki Activity

Fix #109040: Don't calculate homogenous offset if viewspace offset is zero #109657

Merged
Clément Foucault merged 1 commits from bonj/blender:fix/retopology-offset-math into main 2023-07-11 11:44:25 +02:00
Conversation 1 Commits 1 Files Changed 1 +5 -1
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
source/blender/draw/intern/shaders/common_view_lib.glsl
View File

@ -262,7 +262,11 @@ vec3 point_world_to_view(vec3 p)
* Offset is in viewspace, so positive values are closer to the camera. */
float get_homogenous_z_offset(float vs_z, float hs_w, float vs_offset)
{
if (ProjectionMatrix[3][3] == 0.0) {
if (vs_offset == 0.0) {
/* Don't calculate homogenous offset if viewspace offset is zero. */
return 0.0;
}
else if (ProjectionMatrix[3][3] == 0.0) {
/* Clamp offset to half of Z to avoid floating point precision errors. */
vs_offset = min(vs_offset, vs_z * -0.5);
/* From "Projection Matrix Tricks" by Eric Lengyel: