Fix #109583: Avoid allocation new custom loop normals for write #109696

Closed

Iliya Katushenock wants to merge 6 commits from mod_moder:tmp_fix_data_race_to_compute_normals into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Iliya Katushenock commented

2023-07-04 15:18:28 +02:00

Member

3a3d9488a1 was cause memory leask for Curve Deform node.
And after few changes, this involk crash.
This used to be a leaked copy made by each node
to write its own version of the custom loop normals.

https://projects.blender.org/blender/blender/commit/3a3d9488a1633bfefabbab422dd22283bca02626 was cause memory leask for Curve Deform node. And after few changes, this involk crash. This used to be a leaked copy made by each node to write its own version of the custom loop normals.

Iliya Katushenock added the

label 2023-07-04 15:18:28 +02:00

Iliya Katushenock added 5 commits 2023-07-04 15:18:38 +02:00

cc571a2b1a init

0fd640c533 cleanup

b713c4c8cf progress

11e589e574 p

2dc30b191e p

Iliya Katushenock added this to the Nodes & Physics project 2023-07-04 15:18:44 +02:00

Iliya Katushenock requested review from Jacques Lucke 2023-07-04 15:18:52 +02:00

Iliya Katushenock requested review from Hans Goudey 2023-07-04 15:18:52 +02:00

Hans Goudey reviewed 2023-07-04 16:14:38 +02:00

source/blender/blenkernel/intern/mesh.cc Outdated

						
				@ -1798,3 +1798,1 @@

				  /* may be nullptr */

				  blender::short2 *clnors = (blender::short2 *)CustomData_get_layer_for_write(

				      &mesh->ldata, CD_CUSTOMLOOPNORMAL, mesh->totloop);

				  /* May be nullptr. Const_cast to avoid data race while normals computing from different threads

Hans Goudey commented

2023-07-04 16:14:38 +02:00

Member

Suggestion for the comment:

May be null. The `const_cast` avoids reallocating the layer's data when making it mutable, which can result in memory leaks when this function is run from multiple threads. `clnors` is written to in rare cases when invalid data is found. Ideally they would not be written to, but this is the simplest way to maintain existing behavior.

Suggestion for the comment: ``` May be null. The `const_cast` avoids reallocating the layer's data when making it mutable, which can result in memory leaks when this function is run from multiple threads. `clnors` is written to in rare cases when invalid data is found. Ideally they would not be written to, but this is the simplest way to maintain existing behavior. ```

mod_moder marked this conversation as resolved

Iliya Katushenock added 1 commit 2023-07-04 16:22:38 +02:00

70d8f36928 comment

Jacques Lucke commented

2023-07-10 13:44:26 +02:00

Member

Seems ok as a temporary solution, but will leave it to Hans to decide whether this is fine for now or whether a bigger change should be done first.

Seems ok as a temporary solution, but will leave it to Hans to decide whether this is fine for now or whether a bigger change should be done first.

Jacques Lucke refused to review 2023-07-10 13:44:30 +02:00

Hans Goudey commented

2023-07-16 14:45:24 +02:00

Member

Reading split_loop_nor_fan_do I'm a little less sure that this is okay. The "invalid" situation is when the custom normals in a smooth fan don't all match. The corners contained in smooth fans change as edges are marked sharp (or even as the mesh deforms with auto smooth). So if multiple differently deformed meshes share the same custom normals array, they will each write their own averaged custom normals into different groups of corners.

Without changing edge sharpness this isn't an issue, but I don't think we can just ignore that case unfortunately.

I think the proper solution, especially longer term, is to just avoid writing into custom normals completely. It just isn't a threadsafe thing to do, that's especially obvious in the drawing code. I started that here:

https://projects.blender.org/blender/blender/compare/main...HooglyBoogly:fix-no-custom-normals-write

When I'm back I'll take another look at that to make sure it doesn't have any unexpected consequences. But I don't really see any way around it for now.

Reading `split_loop_nor_fan_do` I'm a little less sure that this is okay. The "invalid" situation is when the custom normals in a smooth fan don't all match. The corners contained in smooth fans change as edges are marked sharp (or even as the mesh deforms with auto smooth). So if multiple differently deformed meshes share the same custom normals array, they will each write their own averaged custom normals into different groups of corners. Without changing edge sharpness this isn't an issue, but I don't think we can just ignore that case unfortunately. I think the proper solution, especially longer term, is to just avoid writing into custom normals completely. It just isn't a threadsafe thing to do, that's especially obvious in the drawing code. I started that here: https://projects.blender.org/blender/blender/compare/main...HooglyBoogly:fix-no-custom-normals-write When I'm back I'll take another look at that to make sure it doesn't have any unexpected consequences. But I don't really see any way around it for now.

Hans Goudey closed this pull request

2023-07-16 14:45:25 +02:00

Iliya Katushenock deleted branch tmp_fix_data_race_to_compute_normals

2023-07-16 14:52:40 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#109696

No description provided.