View 3D: Refactor code to split functions and remove duplication #109760

Germano Cavalcante · 2023-07-05T21:35:10+02:00

2023-07-05 21:35:10 +02:00

No functional changes.

Previously, each navigation operation had its own method for restoring
the 3D View's state upon cancellation.

However, this approach did not provide significant advantages.

The number of affected variables was too small to justify considering
it for performance optimization, and the cancellation code was
duplicated across different operations.

To address this, the present commit unifies all restore code into a
single function:

void viewops_data_state_restore(ViewOpsData *vod);

As a result, the viewmove_apply_reset function has been removed.

Moreover, since the state now has a dedicated restore function, it
seemed appropriate to create a function for capturing the state as
well.

Therefore, the code responsible for capturing the state (previously
scattered within viewops_data_init_navigation) has been extracted to
create the function:

void viewops_data_state_capture(ViewOpsData *vod);

During this separation process, a potential error in the code was
identified, where the state may not be fully restored.

Although this issue persists, a comment has been added to clarify this
situation.

This change stemmed from an idea to always allow navigation for the transform's Set Snap Base mode. In this case, it might be interesting to restore the view after setting the Snap Base.

No functional changes. Previously, each navigation operation had its own method for restoring the 3D View's state upon cancellation. However, this approach did not provide significant advantages. The number of affected variables was too small to justify considering it for performance optimization, and the cancellation code was duplicated across different operations. To address this, the present commit unifies all restore code into a single function: - `void viewops_data_state_restore(ViewOpsData *vod);` As a result, the `viewmove_apply_reset` function has been removed. Moreover, since the state now has a dedicated restore function, it seemed appropriate to create a function for capturing the state as well. Therefore, the code responsible for capturing the state (previously scattered within `viewops_data_init_navigation`) has been extracted to create the function: - `void viewops_data_state_capture(ViewOpsData *vod);` During this separation process, a potential error in the code was identified, where the state may not be fully restored. Although this issue persists, a comment has been added to clarify this situation. --- This change stemmed from an idea to always allow navigation for the transform's `Set Snap Base` mode. In this case, it might be interesting to restore the view after setting the Snap Base.

👍 1

Germano Cavalcante requested review from Brecht Van Lommel 2023-07-05 21:35:34 +02:00

Germano Cavalcante requested review from Campbell Barton 2023-07-05 21:35:35 +02:00

Germano Cavalcante force-pushed cleanup_navigation from e645cc36bf to fd9e3219b0

2023-07-06 18:10:47 +02:00

Compare

Germano Cavalcante merged commit d9829c2f87 into main

2023-07-06 18:21:43 +02:00

Germano Cavalcante referenced this issue from a commit

2023-07-06 18:21:44 +02:00

View 3D: Refactor code to split functions and remove duplication

Germano Cavalcante deleted branch cleanup_navigation