Animation: Allow setting the slider unit and mode #109768

Christoph Lendenfeld · 2023-07-06T10:37:04+02:00

2023-07-06 10:37:04 +02:00

Split off from #106952: Animation: Butterworth Smoothing filter

This patch allows the slider to take a different string than just "%",
the use case is on #106952 where we want to display "Hz" instead.

Additionally the slider got the ability to set modes, which determine
how the factor number is displayed.
SLIDER_MODE_PERCENT means it will multiply by 100 and display as whole numbers
SLIDER_MODE_FLOAT means it will display just floats with one digit after the comma

Additionally to that, because the slider range is now arbitrary and potentially deals with
large numbers, the mouse distance needed to travel from min to max has been normalized
to the range.

Split off from [#106952: Animation: Butterworth Smoothing filter](https://projects.blender.org/blender/blender/pulls/106952) This patch allows the slider to take a different string than just "%", the use case is on #106952 where we want to display "Hz" instead. Additionally the slider got the ability to set modes, which determine how the factor number is displayed. `SLIDER_MODE_PERCENT` means it will multiply by 100 and display as whole numbers `SLIDER_MODE_FLOAT` means it will display just floats with one digit after the comma Additionally to that, because the slider range is now arbitrary and potentially deals with large numbers, the mouse distance needed to travel from min to max has been normalized to the range.

🚀 1

Christoph Lendenfeld added the

Module

Animation & Rigging

label 2023-07-06 10:37:04 +02:00

Christoph Lendenfeld added 1 commit 2023-07-06 10:37:10 +02:00

allow setting the slider unit 41a213574a

Christoph Lendenfeld requested review from Sybren A. Stüvel 2023-07-06 10:37:23 +02:00

Christoph Lendenfeld added this to the Animation & Rigging project 2023-07-06 10:37:32 +02:00

Sybren A. Stüvel requested changes 2023-07-06 11:49:54 +02:00

Sybren A. Stüvel left a comment

I think it would be better to copy the unit_string into slider-owned memory. That way the caller of the ED_slider_unit_set() function doesn't have to ensure that the string outlives the slider.

It's probably fine to use char unit_string[64]; as we won't have many (if any) sliders active simultaneously, and 64 bytes seems plenty for this. Even with non-ASCII characters it would allow for at least 8, which I think is fine for abbreviations of units.

I think it would be better to copy the `unit_string` into slider-owned memory. That way the caller of the `ED_slider_unit_set()` function doesn't have to ensure that the string outlives the slider. It's probably fine to use `char unit_string[64];` as we won't have many (if any) sliders active simultaneously, and 64 bytes seems plenty for this. Even with non-ASCII characters it would allow for at least 8, which I think is fine for abbreviations of units.

Christoph Lendenfeld added 1 commit 2023-07-06 15:41:48 +02:00

use strncopy for unit string d6ad2f98d4

Christoph Lendenfeld commented

2023-07-06 15:46:47 +02:00

@sybren I used strcpy to copy onto the char[64]
I am a bit surprised it doesn't take a string length parameter, but I assume that is ok?

@sybren I used `strcpy` to copy onto the `char[64]` I am a bit surprised it doesn't take a string length parameter, but I assume that is ok?

Christoph Lendenfeld requested review from Sybren A. Stüvel 2023-07-06 15:46:54 +02:00

Sybren A. Stüvel commented

2023-07-06 17:04:35 +02:00

You can use BLI_strncpy() instead

You can use `BLI_strncpy()` instead

Christoph Lendenfeld added 1 commit 2023-07-06 17:50:44 +02:00