Transform: Support navigation from NDOF devices #109792

Germano Cavalcante · 2023-07-06T19:00:36+02:00

2023-07-06 19:00:36 +02:00

This commit implements the VIEW3D_OT_ndof_orbit,
VIEW3D_OT_ndof_orbit_zoom, VIEW3D_OT_ndof_pan and
VIEW3D_OT_ndof_all operators to the ED_view3d_navigation_
navigation utility so that these operations can be used in the
transform operators.

Builds:
https://builder.blender.org/download/patch/PR109792/

This commit implements the `VIEW3D_OT_ndof_orbit`, `VIEW3D_OT_ndof_orbit_zoom`, `VIEW3D_OT_ndof_pan` and `VIEW3D_OT_ndof_all` operators to the `ED_view3d_navigation_` navigation utility so that these operations can be used in the transform operators. **Builds:** https://builder.blender.org/download/patch/PR109792/

Germano Cavalcante added the

Module

Modeling

label 2023-07-06 19:00:36 +02:00

Germano Cavalcante requested review from Dalai Felinto 2023-07-06 19:01:43 +02:00

Germano Cavalcante commented

2023-07-06 19:02:24 +02:00

This patch needs testing. Currently I don't own any NDOF device.

@blender-bot package

This patch needs testing. Currently I don't own any NDOF device. @blender-bot package

Blender Bot commented

2023-07-06 19:02:27 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109792) when ready.

Germano Cavalcante requested review from Campbell Barton 2023-07-06 19:02:54 +02:00

Dalai Felinto commented

2023-07-07 10:35:03 +02:00

Hi,

I tested it (with Sergey). My thoughts:

It works but ...
I still had to turn navigation transform in the user preference for it to work.
It is a bit strange to rotate like this and have the mouse still hanging elsewhere and the object "following" the mouse. Effectively it means you are moving the object while orbiting. It is probably the same case for trackpads though.

Hi, I tested it (with Sergey). My thoughts: * It works but ... * I still had to turn navigation transform in the user preference for it to work. * It is a bit strange to rotate like this and have the mouse still hanging elsewhere and the object "following" the mouse. Effectively it means you are moving the object while orbiting. It is probably the same case for trackpads though.

Germano Cavalcante commented

2023-07-07 15:19:44 +02:00

I still had to turn navigation transform in the user preference for it to work.

Removing the Navigate during transform option depends on #109754.
However, as the patch here touches an area that is affected by the other one, and the other one is still WIP, it would be interesting to apply this one first.

> I still had to turn navigation transform in the user preference for it to work. Removing the `Navigate during transform` option depends on #109754. However, as the patch here touches an area that is affected by the other one, and the other one is still WIP, it would be interesting to apply this one first.

Dalai Felinto approved these changes 2023-07-07 15:42:16 +02:00

Dalai Felinto left a comment

Right, well as far as NDOF is concerned the patch seems fine then (the other issues being common to trackpad or discussed on #109754). I didn't check the code though.

Germano Cavalcante force-pushed support_ndof from 4c17efffa5 to dcb7ad36cb

2023-07-08 02:28:32 +02:00

Compare

Germano Cavalcante commented

2023-07-08 02:33:18 +02:00

I have implemented a fix (in dcb7ad36cb) that makes navigation operators coming from trackpad or NDOF behave similarly to mouse ones.

I'll also wait for @ideasman42 's tests (if it seems necessary).

@blender-bot package

I have implemented a fix (in dcb7ad36cb) that makes navigation operators coming from trackpad or NDOF behave similarly to mouse ones. I'll also wait for @ideasman42 's tests (if it seems necessary). @blender-bot package

Blender Bot commented

2023-07-08 02:33:23 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109792) when ready.

Germano Cavalcante merged commit 37d1d4cb07 into main

2023-07-10 14:57:48 +02:00

Germano Cavalcante referenced this issue from a commit

2023-07-10 14:57:49 +02:00

Transform: Support navigation from NDOF devices

Germano Cavalcante deleted branch support_ndof

2023-07-10 14:57:49 +02:00

Andras-Borsanyi referenced this issue from a commit