blender
/
blender
135
420
Fork 603
Code Issues 6.3k Pull Requests 754 Projects 19 Wiki Activity

Fix #109781: Linked datablocks are keyable #109813

Merged
Christoph Lendenfeld merged 3 commits from ChrisLend/blender:fix_lib_override_keyframes into main 2023-07-13 14:09:56 +02:00
Conversation 1 Commits 3 Files Changed 1 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit dd76f2b74a - Show all commits

2
source/blender/editors/animation/keyframing.cc
View File

@ -1498,7 +1498,7 @@ int insert_keyframe(Main *bmain,
}
if (!BKE_id_is_editable(bmain, id)) {
BKE_reportf(reports, RPT_ERROR, "ID block for %s is not editable", rna_path);
BKE_reportf(reports, RPT_ERROR, "'%s' on %s is not editable", rna_path, id->name + 2);
Sybren A. Stüvel commented 2023-07-07 14:50:48 +02:00
Outdated
Review
Copy Link

AFAIK in the UI it's only "data-block", not "ID" or "ID block".

Do you think BKE_reportf(reports, RPT_ERROR, "Data-block %s for %s is not editable", id->name+2, rna_path); would work? It doesn't say what kind the data-block is (hence the +2), but at least the name is explicit in the message.

AFAIK in the UI it's only "data-block", not "ID" or "ID block". Do you think `BKE_reportf(reports, RPT_ERROR, "Data-block %s for %s is not editable", id->name+2, rna_path);` would work? It doesn't say what kind the data-block is (hence the `+2`), but at least the name is explicit in the message.
Christoph Lendenfeld commented 2023-07-07 15:21:46 +02:00
Outdated
Review
Copy Link

I just used ID block because it was used a few lines above that as well
But I changed it to e.g. 'location' on Cube is not editable

I had tried your solution but Data-block Cube for location is not editable sounded a bit weird

I just used ID block because it was used a few lines above that as well But I changed it to e.g. `'location' on Cube is not editable` I had tried your solution but `Data-block Cube for location is not editable` sounded a bit weird
Sybren A. Stüvel commented 2023-07-07 17:15:14 +02:00
Outdated
Review
Copy Link

Yeah, yours is much better!

Yeah, yours is much better!
Christoph Lendenfeld commented 2023-07-07 17:47:25 +02:00
Outdated
Review
Copy Link

can I get a green tick on this then? :D

can I get a green tick on this then? :D
return 0;
}