EEVEE Next: Point Clouds #109832

Miguel Pozo · 2023-07-07T20:14:05+02:00

Miguel Pozo commented

2023-07-07 20:14:05 +02:00

Add support for point cloud rendering in EEVEE Next.
It also updates point_cloud_sub_pass_setup to retrieve texture based attributes,
since that's the way they're actually meant to be used.

I had to include common_pointcloud_lib into eevee_attributes_lib, which is not super great and some workarounds were required. Maybe attribute loading functions could be moved to their respective vertex/fragment shaders?

Add support for point cloud rendering in EEVEE Next. It also updates `point_cloud_sub_pass_setup` to retrieve texture based attributes, since that's the way they're actually meant to be used. - I had to include `common_pointcloud_lib` into `eevee_attributes_lib`, which is not super great and some workarounds were required. Maybe attribute loading functions could be moved to their respective vertex/fragment shaders?

Miguel Pozo added the

Module

EEVEE & Viewport

label 2023-07-07 20:14:05 +02:00

Miguel Pozo added 7 commits 2023-07-07 20:14:19 +02:00

Miguel Pozo added this to the EEVEE & Viewport project 2023-07-07 20:14:34 +02:00

Miguel Pozo requested review from Clément Foucault 2023-07-10 15:35:39 +02:00

Miguel Pozo added 2 commits 2023-07-10 18:32:09 +02:00

080b2d6c56 Use the correct subpass

f26a774b2b Fix motion blur

Clément Foucault requested changes 2023-07-13 23:57:12 +02:00

Clément Foucault left a comment

Looks good! Was not able to test on Metal because of another bug but compilation of tests shaders passes.

I would just like to remove the complexity of the vertex shader like suggested. Otherwise it's good to go.

Looks good! Was not able to test on Metal because of another bug but compilation of tests shaders passes. I would just like to remove the complexity of the vertex shader like suggested. Otherwise it's good to go.

source/blender/draw/engines/eevee_next/eevee_shader.cc Outdated

						
				@ -382,3 +383,2 @@

				  {

				    /* Only mesh and curves support vertex displacement for now. */

				    if (ELEM(geometry_type, MAT_GEOM_MESH, MAT_GEOM_CURVES, MAT_GEOM_GPENCIL)) {

				    if (ELEM(

Clément Foucault commented

2023-07-13 22:59:12 +02:00

At this point, just test for MAT_GEOM_VOLUME and MAT_GEOM_WORLD.

pragma37 marked this conversation as resolved

source/blender/draw/engines/eevee_next/shaders/eevee_geom_point_cloud_vert.glsl Outdated

						
				@ -0,0 +21,4 @@

				  mat3 facing_mat;

				  {

				    /* Same logic as pointcloud_get_facing_matrix(), but ensuring we use the actual camera matrices

Clément Foucault commented

2023-07-13 23:27:37 +02:00

I guess the issue you had is that shadow map geometry was not matching the camera one producing self shadowing.
Instead of making the shadow camera dependent (that does not work with shadow map caching), I suggest to add a bias in the shadow map shader for point cloud. From my calculation, a bias equal to the point radius should be enough to remove any self shadowing.

This should remove the need for all this logic.

I guess the issue you had is that shadow map geometry was not matching the camera one producing self shadowing. Instead of making the shadow camera dependent (that does not work with shadow map caching), I suggest to add a bias in the shadow map shader for point cloud. From my calculation, a bias equal to the point radius should be enough to remove any self shadowing. This should remove the need for all this logic.

pragma37 marked this conversation as resolved

source/blender/draw/engines/eevee_next/shaders/infos/eevee_material_info.hh Outdated

						
				@ -41,0 +41,4 @@

				GPU_SHADER_INTERFACE_INFO(eevee_surf_point_cloud_iface, "point_cloud_interp")

				    .smooth(Type::FLOAT, "radius")

				    .smooth(Type::VEC3, "position")

				    .flat(Type::INT, "ID");

Clément Foucault commented

2023-07-13 23:31:46 +02:00

no uppercase.

pragma37 marked this conversation as resolved

source/blender/draw/engines/eevee_next/shaders/infos/eevee_material_info.hh Outdated

						
				@ -41,0 +48,4 @@

				    .define("MAT_GEOM_POINT_CLOUD")

				    .vertex_source("eevee_geom_point_cloud_vert.glsl")

				    .vertex_out(eevee_surf_point_cloud_iface)

				    .define("pointRadius", "point_cloud_interp.radius")

Clément Foucault commented

2023-07-13 23:32:58 +02:00

Add todo to remove after old EEVEE is removed.

pragma37 marked this conversation as resolved

source/blender/gpu/shaders/common/gpu_shader_math_rotation_lib.glsl Outdated

						
				@ -155,6 +155,12 @@ Quaternion to_axis_angle(AxisAngle axis_angle)

				  return quat;

				}

				Quaternion from_vector_delta(vec3 from, vec3 to)

Clément Foucault commented

2023-07-13 22:46:59 +02:00

Rename to rotation_between.

Rename to `rotation_between`.

pragma37 marked this conversation as resolved

source/blender/gpu/shaders/common/gpu_shader_math_rotation_lib.glsl Outdated

						
				@ -181,6 +187,13 @@ AxisAngle to_axis_angle(EulerXYZ eul)

				  return to_axis_angle(to_quaternion(eul));

				}

				vec3 rotate(vec3 vector, Quaternion rotation)