Fix #109887: Adding driver from python might crash #109895

Sergey Sharybin · 2023-07-10T09:40:43+02:00

Sergey Sharybin commented

2023-07-10 09:40:43 +02:00

Originally was noticed when adding drivers to a rigid body., but
it could potentially happen with any configuration.

The reason for the crash was that the ID which was modified was
not tagged as such.

Modifying drivers from the interface are likely tagging for updates
from the operator. This change makes it so the python function also
does tagging.

It is not really how one would design the system nowadays, but it
is how the Blender historically handles such cases. A bigger refactor
is possible to move tags to the places where modification actually
happens, but it seems to be a better idea to tackle it as a separate
project which will be considered no-functional-changes.

Originally was noticed when adding drivers to a rigid body., but it could potentially happen with any configuration. The reason for the crash was that the ID which was modified was not tagged as such. Modifying drivers from the interface are likely tagging for updates from the operator. This change makes it so the python function also does tagging. It is not really how one would design the system nowadays, but it is how the Blender historically handles such cases. A bigger refactor is possible to move tags to the places where modification actually happens, but it seems to be a better idea to tackle it as a separate project which will be considered no-functional-changes.

Sergey Sharybin added the

Module

Animation & Rigging

label 2023-07-10 09:40:43 +02:00

Sergey Sharybin added 1 commit 2023-07-10 09:40:54 +02:00

22e42adf6e Fix #109887 : Adding driver from python might crash

Originally was noticed when adding drivers to a rigid body., but
it could potentially happen with any configuration.

The reason for the crash was that the ID which was modified was
not tagged as such.

Modifying drivers from the interface are likely tagging for updates
from the operator. This change makes it so the python function also
does tagging.

It is not really how one would design the system nowadays, but it
is how the Blender historically handles such cases. A bigger refactor
is possible to move tags to the places where modification actually
happens, but it seems to be a better idea to tackle it as a separate
project which will be considered no-functional-changes.

Sergey Sharybin requested review from Sybren A. Stüvel 2023-07-10 09:41:32 +02:00

Sybren A. Stüvel approved these changes 2023-07-10 09:55:55 +02:00

Sybren A. Stüvel commented

2023-07-10 09:56:20 +02:00

Do you think this should go jnto 3.6?

Sybren A. Stüvel added this to the Animation & Rigging project 2023-07-10 09:56:57 +02:00

Sergey Sharybin commented

2023-07-10 10:08:08 +02:00

It does seem safe to go to 3.6, yes.
The commit still needs to happen to main, and then cherry-picked. I'll add it to the cherry-pick list after the merge to main.

It does seem safe to go to 3.6, yes. The commit still needs to happen to main, and then cherry-picked. I'll add it to the cherry-pick list after the merge to main.

👍 1

Sergey Sharybin merged commit 9314f97afd into main

2023-07-10 10:11:52 +02:00

Sergey Sharybin deleted branch fix_109887

2023-07-10 10:11:54 +02:00

Sergey Sharybin referenced this issue from a commit

2023-07-10 10:11:56 +02:00

Fix #109887: Adding driver from python might crash

Philipp Oeser referenced this issue from a commit

2023-07-12 15:46:05 +02:00

Fix #109887: Adding driver from python might crash

Andras-Borsanyi referenced this issue from a commit