blender/blender

WIP: Avoid unintentional 3D View inheritance #110019

Closed

Julien Kaspar wants to merge 1 commits from JulienKaspar:3d-view-inheritance into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Julien Kaspar commented

2023-07-12 18:45:55 +02:00

Member

Based on design task: #105298

General Info

This change makes generic transform operators more mode specific. This avoids unwanted/unnecessary keybindings in various nodes.

This change is needed for #108712.

NOTE: This PR is currently not building correctly and needs some fixes.

Changes

Move, Rotate and Scale operations are moved into their own function instead of 3D View (Global).
This function is then pasted into any mode that requires it.

Other operations like Shear, To Sphere, Mirror, Bend, Skin Resize & Transform Axis Target are pasted into each mode where they are required/supported.

Based on design task: #105298 # General Info This change makes generic transform operators more mode specific. This avoids unwanted/unnecessary keybindings in various nodes. This change is needed for #108712. NOTE: This PR is currently not building correctly and needs some fixes. # Changes **Move**, **Rotate** and **Scale** operations are moved into their own function instead of 3D View (Global). This function is then pasted into any mode that requires it. Other operations like **Shear**, **To Sphere**, **Mirror**, **Bend**, **Skin Resize** & **Transform Axis Target** are pasted into each mode where they are required/supported.

Julien Kaspar added this to the 4.0 milestone 2023-07-12 18:45:55 +02:00

Julien Kaspar added the

Animation & Rigging

Sculpt, Paint & Texture

Nodes & Physics

labels 2023-07-12 18:45:56 +02:00

Julien Kaspar added 1 commit 2023-07-12 18:46:02 +02:00

Rearranging of transform operators. 2485ec0188

Allows operators to be more mode specific.

Julien Kaspar referenced this pull request

2023-07-12 18:47:10 +02:00

Sculpt/Painting Modes: Revamp Keymap #105298

Julien Kaspar referenced this pull request

2023-07-19 10:53:34 +02:00

Simplify default keymap for paint modes #108712

Campbell Barton requested changes 2023-07-21 09:10:16 +02:00

Campbell Barton left a comment

Owner

Requesting changes although it's just a minor tweak to avoid duplication for bend/mirror key-map items.

Requesting changes although it's just a minor tweak to avoid duplication for bend/mirror key-map items.

scripts/presets/keyconfig/keymap_data/blender_default.py

						
				@ -332,6 +332,22 @@ def _template_space_region_type_toggle(*, toolbar_key=None, sidebar_key=None, ch

				    return items

				def _template_items_transform_actions(params):

Campbell Barton commented

2023-07-21 09:09:33 +02:00

Owner

To keep shared keys central, this function can take keyword only arguments:

def _template_items_transform_actions(params, *, use_mirror=False, use_bend=False):

... then callers that use these operators can call this function with them set.

To keep shared keys central, this function can take keyword only arguments: `def _template_items_transform_actions(params, *, use_mirror=False, use_bend=False):` ... then callers that use these operators can call this function with them set.

Campbell Barton referenced this issue from a commit

2023-07-25 13:23:46 +02:00

Keymap: avoid 3D View transform inheritance

Campbell Barton commented

2023-07-25 13:34:56 +02:00

Owner

Committed d7558a243c with edits, closing.

Committed d7558a243c6b3b48669d7c084ff0cfbbc5324e6a with edits, closing.

Campbell Barton closed this pull request

2023-07-25 13:34:58 +02:00

Julien Kaspar referenced this pull request

2023-07-25 15:46:28 +02:00

Simplify default keymap for paint modes #108712

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Automated Testing

Blender Asset Bundle

Code Documentation

Dependency Graph

Development Management

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Viewport & EEVEE

Virtual Reality

Asset Browser Project

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Viewport & EEVEE

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#110019

No description provided.