I18n: make the string holding light cache messages longer #110028

Merged
Bastien Montagne merged 1 commits from pioverfour/blender:dp_extend_light_cache_string into main 2023-07-17 11:46:12 +02:00
Member

The light_cache_info string holds information about the outcome of
Eevee light cache baking. It is currently 64 bits, which is enough to
hold all possible messages in English. However, some messages need to
be longer than this in other languages, so the holding string also
needs to be longer. From what I can tell, 128 bytes is plenty enough.


@mont29 This is similar to !109408, but this string a tooltip-like one, so I think it’s okay to make it longer. I’ve tried to make it as short as possible in French, but as you know there is some unavoidable verbosity there. 😅
Let me know what you think!

image
image
image

(Also this is out of scope for this issue, but I’m still looking for a way to make this string dynamic so that if the language changes, it changes too, but I don’t really know how to do that yet.)

The `light_cache_info` string holds information about the outcome of Eevee light cache baking. It is currently 64 bits, which is enough to hold all possible messages in English. However, some messages need to be longer than this in other languages, so the holding string also needs to be longer. From what I can tell, 128 bytes is plenty enough. ----- @mont29 This is similar to !109408, but this string a tooltip-like one, so I think it’s okay to make it longer. I’ve tried to make it as short as possible in French, but as you know there is some unavoidable verbosity there. 😅 Let me know what you think! ![image](/attachments/7ad81b3b-ce5d-4ff3-8408-278bb6a97ea4) ![image](/attachments/d9417464-51df-44dd-a7f1-f098112638ce) ![image](/attachments/d436dc22-80d3-4fa2-8329-c0d67bf05398) (Also this is out of scope for this issue, but I’m still looking for a way to make this string dynamic so that if the language changes, it changes too, but I don’t really know how to do that yet.)
Damien Picard added the
Module
User Interface
Interest
Translations
labels 2023-07-12 20:32:36 +02:00
Damien Picard added 1 commit 2023-07-12 20:32:46 +02:00
c6230a4733 I18n: make the string holding light cache messages longer
The `light_cache_info` string holds information about the outcome of
Eevee light cache baking. It is currently 64 bits, which is enough to
hold all possible messages in English. However, some messages need to
be longer than this in other languages, so the holding string also
needs to be longer. From what I can tell, 128 bytes is plenty enough.
Damien Picard requested review from Bastien Montagne 2023-07-12 20:32:52 +02:00
Bastien Montagne approved these changes 2023-07-17 11:45:47 +02:00
Bastien Montagne merged commit f9669d0a11 into main 2023-07-17 11:46:12 +02:00
Bastien Montagne deleted branch dp_extend_light_cache_string 2023-07-17 11:46:14 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#110028
No description provided.