blender
/
blender
134
398
Fork 579
Code Issues 6.3k Pull Requests 754 Projects 19 Wiki Activity

EEVEE Next: Motion Blur fixes #110114

Merged
Clément Foucault merged 7 commits from pragma37/blender:pull-eevee-next-motion-blur-fixes into main 2023-08-03 12:48:22 +02:00
Conversation 0 Commits 7 Files Changed 13 +156 -93
Miguel Pozo commented 2023-07-14 21:22:25 +02:00
Member
Copy Link

Fix motion blur for viewport re-projection and final image renders.

Fix motion blur for viewport re-projection and final image renders.
Miguel Pozo added this to the EEVEE & Viewport project 2023-07-14 21:22:47 +02:00
Miguel Pozo added the
Module
EEVEE & Viewport
 label 2023-07-14 21:23:15 +02:00
Clément Foucault approved these changes 2023-07-15 14:37:38 +02:00
source/blender/draw/engines/eevee_next/shaders/eevee_motion_blur_flatten_comp.glsl Outdated
@ -52,6 +52,7 @@ void main()
float depth = texelFetch(depth_tx, texel, 0).r;
vec4 motion = velocity_resolve(imageLoad(velocity_img, texel), uv, depth);
#ifdef FLATTEN_VIEWPORT
/* TODO(Miguel Pozo): ??? */
Clément Foucault commented 2023-07-15 14:37:12 +02:00
Member
Copy Link

??????

??????
pragma37 marked this conversation as resolved
source/blender/draw/engines/eevee_next/shaders/eevee_surf_depth_frag.glsl Outdated
@ -42,6 +42,7 @@ void main()
#endif
#ifdef MAT_VELOCITY
/* TODO(Miguel Pozo): Couldn't this be done in the vertex shader? */
Clément Foucault commented 2023-07-15 14:37:00 +02:00
Member
Copy Link

Interpolating screen uv velocity isn't going to give you correct results.

Interpolating screen uv velocity isn't going to give you correct results.
pragma37 marked this conversation as resolved
Miguel Pozo force-pushed pull-eevee-next-motion-blur-fixes from a0778f02d8 to 3c21d95b71 2023-07-19 18:58:37 +02:00 Compare
Miguel Pozo requested review from Clément Foucault 2023-07-19 18:59:40 +02:00
Miguel Pozo force-pushed pull-eevee-next-motion-blur-fixes from 3c21d95b71 to 5c5e09612d 2023-07-19 19:04:35 +02:00 Compare
Miguel Pozo changed title from WIP: EEVEE Next: Motion Blur fixes to EEVEE Next: Motion Blur fixes 2023-07-19 19:09:03 +02:00
Miguel Pozo force-pushed pull-eevee-next-motion-blur-fixes from 5c5e09612d to 555a958e3f 2023-07-20 15:43:15 +02:00 Compare
Clément Foucault reviewed 2023-08-01 15:09:25 +02:00
source/blender/draw/engines/eevee_next/eevee_motion_blur.cc Outdated
@ -238,3 +237,1 @@
inst_.manager->submit(motion_blur_ps_, view);
tiles_tx_.release();
const bool swizzle_vector_tx = inst_.render_buffers.vector_tx_format() == GPU_RG16F;
Clément Foucault commented 2023-08-01 13:23:19 +02:00
Member
Copy Link

Avoid the _tx suffix. It is reserved for textures. do_motion_vector_swizzle seems better.

Avoid the `_tx` suffix. It is reserved for textures. `do_motion_vector_swizzle` seems better.
pragma37 marked this conversation as resolved
source/blender/draw/engines/eevee_next/eevee_sync.hh Outdated
@ -181,2 +181,4 @@
};
template<typename F>
void foreach_hair_particle_handle(Object *ob, ObjectHandle ob_handle, F callback)
Clément Foucault commented 2023-08-01 13:19:06 +02:00
Member
Copy Link

Maybe use FunctionRef instead of template.

Maybe use FunctionRef instead of template.
pragma37 marked this conversation as resolved
source/blender/draw/engines/eevee_next/eevee_velocity.cc Outdated
@ -200,4 +264,2 @@
void VelocityModule::step_swap()
{
{
/* Now that vertex buffers are guaranteed to be updated, proceed with
Clément Foucault commented 2023-07-22 21:37:22 +02:00
Member
Copy Link

Why remove this comment?

Why remove this comment?
Miguel Pozo commented 2023-08-01 17:19:06 +02:00
Author
Member
Copy Link

I've added it back to geometry_steps_fill.
I've removed the "Now that vertex buffers are guaranteed to be updated", since that's not something that the function itself can actually guarantee.

I've added it back to `geometry_steps_fill`. I've removed the "Now that vertex buffers are guaranteed to be updated", since that's not something that the function itself can actually guarantee.
Clément Foucault commented 2023-08-01 17:43:53 +02:00
Member
Copy Link

Yes but it is guaranteed because it is supposed to be called after sync or viewport drawing. Maybe the comment need to be modified to include that.

Yes but it is guaranteed because it is supposed to be called after sync or viewport drawing. Maybe the comment need to be modified to include that.
Miguel Pozo commented 2023-08-01 17:58:30 +02:00
Author
Member
Copy Link

How about moving the comment to the header file?

/* Perform VelocityGeometryData offset computation and copy into the geometry step buffer.
 * Should be called after all the vertex buffers have been updated by step_object_sync. */
void geometry_steps_fill();
How about moving the comment to the header file? ```cpp /* Perform VelocityGeometryData offset computation and copy into the geometry step buffer. * Should be called after all the vertex buffers have been updated by step_object_sync. */ void geometry_steps_fill(); ```
Clément Foucault commented 2023-08-01 18:19:59 +02:00
Member
Copy Link

Change it to Should be called after all the vertex buffers have been updated by batch cache extraction. and it good.

Change it to `Should be called after all the vertex buffers have been updated by batch cache extraction.` and it good.
Miguel Pozo commented 2023-08-01 19:05:31 +02:00
Author
Member
Copy Link

Oooops!
Done. :)

Oooops! Done. :)
pragma37 marked this conversation as resolved
Miguel Pozo added 1 commit 2023-08-01 17:15:51 +02:00
Miguel Pozo added 1 commit 2023-08-01 19:04:55 +02:00
Clément Foucault approved these changes 2023-08-03 12:47:57 +02:00
Clément Foucault merged commit 9db289924f into main 2023-08-03 12:48:22 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Clément Foucault
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
EEVEE & Viewport
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#110114
No description provided.
Delete Branch "pragma37/blender:pull-eevee-next-motion-blur-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?