blender
/
blender
137
411
Fork 593
Code Issues 6.3k Pull Requests 768 Projects 19 Wiki Activity

Fix #113552: NLA Markers do not reset when length reaches 0.0 #110121

Merged
Germano Cavalcante merged 2 commits from mano-wii/blender:fix_110108 into blender-v4.0-release 2023-10-16 16:46:56 +02:00
Conversation 11 Commits 2 Files Changed 1 +14 -3

2 Commits

Author SHA1 Message Date
Germano Cavalcante 79cc6ba238 Improve comment 2023-10-16 10:05:17 -03:00
Germano Cavalcante 4d08b7f2f2 Fix #110108: NLA Markers transform not resetting correctly 
Caused by bd00324c26.

bd00324c26 allowed `strip->start` to have the same value as
`strip->end` (ignoring the `NLASTRIP_MIN_LEN_THRESH`).

So `oLen` can be `0.0f` in `BKE_nlameta_flush_transforms` and create
`nan` when used in division.

This `nan` invalidates later transform operations.

---
I'm not sure if 0-length strips should be allowed. So maybe the fix should be extended to other places.
 2023-10-16 09:57:56 -03:00