Nodes: Move node socket RNA definition into its own file. #110220

Lukas Tönne · 2023-07-17T19:14:57+02:00

Lukas Tönne commented

2023-07-17 19:14:57 +02:00

This is a fairly verbose part of nodes RNA, which defines the base
NodeSocket and NodeSocketInterface types as well as all the subtypes
required for showing correct properties based on socket type.

The RNA for this part of nodes is quite self-contained, so moving it
to a separate files works well and reduces the overall size of
rna_nodetree.cc considerably (~1700 LoC). This does not include any
functional changes.

Moving this to a separate file will make it easier to improve the node
group interface (#109135).

This is a fairly verbose part of nodes RNA, which defines the base NodeSocket and NodeSocketInterface types as well as all the subtypes required for showing correct properties based on socket type. The RNA for this part of nodes is quite self-contained, so moving it to a separate files works well and reduces the overall size of rna_nodetree.cc considerably (~1700 LoC). This does not include any functional changes. Moving this to a separate file will make it easier to improve the node group interface (#109135).

🚀 1

Lukas Tönne added 1 commit 2023-07-17 19:15:12 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

4c53a4f58e Nodes: Move node socket RNA definition into its own file.

This is a fairly verbose part of nodes RNA, which defines the base
NodeSocket and NodeSocketInterface types as well as all the subtypes
required for showing correct properties based on socket type.

The RNA for this part of nodes is quite self-contained, so moving it
to a separate files works well and reduces the overall size of
rna_nodetree.cc considerably (~1700 LoC).

Moving this to a separate file will make it easier to improve the node
group interface (#109135).

Lukas Tönne requested review from Hans Goudey 2023-07-17 19:15:21 +02:00

Lukas Tönne requested review from Jacques Lucke 2023-07-17 19:15:28 +02:00

Lukas Tönne added this to the Nodes & Physics project 2023-07-17 19:15:35 +02:00

Lukas Tönne commented

2023-07-17 19:15:47 +02:00

@blender-bot build

Jacques Lucke approved these changes 2023-07-17 19:26:42 +02:00

Lukas Tönne merged commit 3e3133192a into main

2023-07-18 11:17:40 +02:00

Lukas Tönne referenced this issue from a commit

2023-07-18 11:17:40 +02:00

Nodes: Move node socket RNA definition into its own file.