Refactor: Introduce ViewRender for viewport renders #110244

Sergey Sharybin · 2023-07-18T17:32:45+02:00

Sergey Sharybin commented

2023-07-18 17:32:45 +02:00

A series of no-functional-changes commits which introduce a new concept of a ViewRender which contains render engine, render result, and their mutexes. This opens possibility for the viewport renders to access RenderResult and provide GPUTexture for the render passes.

Ref #108618

A series of no-functional-changes commits which introduce a new concept of a `ViewRender` which contains render engine, render result, and their mutexes. This opens possibility for the viewport renders to access RenderResult and provide `GPUTexture` for the render passes. Ref #108618

Sergey Sharybin added the

Module

Render & Cycles

label 2023-07-18 17:32:45 +02:00

Sergey Sharybin added 8 commits 2023-07-18 17:32:58 +02:00

2542edfe85 Cleanup: Better comments in the RE_engine_draw_acquire()

fcd3ccf9f9 Cleanup: Use C++ style struct definition

27fb75e91c Cleanup: Remove unused field from Render

87df9efd67 Refactor: Use C++ list internally in render pipeline

Used for the global list of the Render structures.

Using C++ container helps moving towards reliable "real" C++
structure for the Render, without worrying about the offset of
the next/prev fields.

Should be no functional changes on the user side.

54431d1844 Refactor: Make Render a real C++ structure

Use proper allocation and destruction for it.

Since the allocation is no longer zero-initialized make sure the
fields are explicitly zeroed out. This also allows to use an easier
way to initialize mutexes.

Currently no functional changes, preparing for a bigger refactor.

1d8f104862 Refactor: Move re-usable parts of Render to a base class

Currently no functional changes.

Preparing for introduction of a Render structure for the viewport
render which will hold both engine and the render result for
passes access.

3c281d8654 Refactor: Allow Render to manage lifetime of resources

buildbot/vexp-code-patch-coordinator Build done. Details

538bdd1280 Refactor: Make viewport to use ViewRender

This change replaces a bare RenderEngine owned by a viewport
with a VeiwRender. This unlocks a possibility of accessing
RenderResult for viewport renders. Currently it is not done,
but it will be needed for an upcoming work towards unification
of the render passes handling.

Ref #108618

Sergey Sharybin commented

2023-07-18 17:33:08 +02:00

@blender-bot build

Sergey Sharybin requested review from Brecht Van Lommel 2023-07-18 18:08:12 +02:00

Brecht Van Lommel approved these changes 2023-07-18 19:09:53 +02:00

Sergey Sharybin referenced this issue from a commit

2023-07-19 12:12:18 +02:00

Refactor: Make viewport to use ViewRender

Sergey Sharybin merged commit ae543c01a4 into main

2023-07-19 12:12:18 +02:00

Sergey Sharybin deleted branch view_render

2023-07-19 12:12:20 +02:00