GPv3: Stroke mode for the Eraser tool #110304

Merged
Falk David merged 12 commits from amelief/blender:gpv3-erase-operator-stroke-mode into main 2023-07-24 17:04:46 +02:00

Implementation of the stroke mode of the eraser tool for grease pencil.
In this mode, the eraser removes each stroke that it touches, meaning each stroke that either intersects the eraser or that has all points inside of it.

Implementation of the stroke mode of the eraser tool for grease pencil. In this mode, the eraser removes each stroke that it touches, meaning each stroke that either intersects the eraser or that has all points inside of it.
Amélie Fondevilla added 9 commits 2023-07-20 15:16:27 +02:00
Amélie Fondevilla changed title from gpv3-erase-operator-stroke-mode to Gpv3: Stroke mode for the Eraser tool 2023-07-20 15:16:56 +02:00
Amélie Fondevilla changed title from Gpv3: Stroke mode for the Eraser tool to GPv3: Stroke mode for the Eraser tool 2023-07-20 15:17:07 +02:00
Amélie Fondevilla added this to the Grease Pencil project 2023-07-20 15:17:15 +02:00
Amélie Fondevilla added 1 commit 2023-07-20 15:26:27 +02:00
Amélie Fondevilla requested review from Falk David 2023-07-20 16:21:20 +02:00
Falk David requested changes 2023-07-21 18:29:58 +02:00
Falk David left a comment
Member

Few comments.

Few comments.
@ -453,0 +462,4 @@
IndexMask strokes_to_remove = IndexMask::from_predicate(
src.curves_range(), GrainSize(256), memory, [&](const int64_t src_curve) {
const IndexRange src_curve_points = src_points_by_curve[src_curve];
BLI_assert(src_curve_points.size() > 0);
Member

I believe curves always have at least one point. So this assert can be removed.

I believe curves always have at least one point. So this assert can be removed.
amelief marked this conversation as resolved
@ -453,0 +468,4 @@
for (const int src_point : src_curve_points.drop_back(1)) {
float mu0;
float mu1;
if (intersections_with_segment(screen_space_positions[src_point],
Member

Since the intersections are unused, maybe it would be better to use dist_to_line_segment_v2 and check if that is less than the radius of the brush.

Since the intersections are unused, maybe it would be better to use `dist_to_line_segment_v2` and check if that is less than the radius of the brush.
amelief marked this conversation as resolved
@ -453,0 +493,4 @@
/* If there is no intersection with the stroke path, then either all points lie inside
* the eraser, or none of them. Thus, checking for the first point should be enough.
*/
return contains_point(screen_space_positions[src_curve_points.first()]);
Member

I believe the comment above also covers this case. So this should then return false;.

I believe the comment above also covers this case. So this should then `return false;`.
amelief marked this conversation as resolved
Amélie Fondevilla added 1 commit 2023-07-21 18:40:55 +02:00
Falk David approved these changes 2023-07-21 18:53:01 +02:00
Falk David left a comment
Member

One more comment, but other than that it LGTM.

One more comment, but other than that it LGTM.
@ -453,0 +474,4 @@
return true;
}
}
Member

There needs to be the check for cyclic curve and the last segment.

There needs to be the check for cyclic curve and the last segment.
filedescriptor marked this conversation as resolved
Falk David added 1 commit 2023-07-24 17:03:10 +02:00
Falk David merged commit 4f56261f76 into main 2023-07-24 17:04:46 +02:00
Falk David deleted branch gpv3-erase-operator-stroke-mode 2023-07-24 17:04:48 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#110304
No description provided.