GPv3: Soft mode for the Eraser tool #110310

Amélie Fondevilla · 2023-07-20T18:16:32+02:00

2023-07-20 18:16:32 +02:00

Implementation of the soft mode of the eraser tool for grease pencil.
In this mode, the eraser decreases the opacity of the points it hits. The new opacity is computed as a minimum between the current opacity and a linear falloff function of the distance of the point to the center of the eraser.
If the opacity of a point falls below a threshold, then the point is removed from the curves.

Implementation of the soft mode of the eraser tool for grease pencil. In this mode, the eraser decreases the opacity of the points it hits. The new opacity is computed as a minimum between the current opacity and a linear falloff function of the distance of the point to the center of the eraser. If the opacity of a point falls below a threshold, then the point is removed from the curves.

Amélie Fondevilla added this to the Grease Pencil project 2023-07-20 18:17:00 +02:00

Amélie Fondevilla requested review from Falk David 2023-07-20 18:17:08 +02:00

hamza.SMA commented

2023-07-20 19:21:38 +02:00

First-time contributor

to confirm, when we reach the threshold , is it creates the new points at the edge of the eraser gizmo? or it create points inside of it ? and thanks for your works, hope enjoy it

Amélie Fondevilla commented

2023-07-21 09:17:50 +02:00

to confirm, when we reach the threshold , is it creates the new points at the edge of the eraser gizmo? or it create points inside of it ? and thanks for your works, hope enjoy it

No, right now it only deletes the points that are transparent, and splits the curve accordingly.
Ideally, we would add new points in between at the positions where the opacity is at the threshold.
I don't think we can have that for this PR thought.

> to confirm, when we reach the threshold , is it creates the new points at the edge of the eraser gizmo? or it create points inside of it ? and thanks for your works, hope enjoy it No, right now it only deletes the points that are transparent, and splits the curve accordingly. Ideally, we would add new points in between at the positions where the opacity is at the threshold. I don't think we can have that for this PR thought.

Amélie Fondevilla changed title from ~~WIP: GPv3: Soft mode for the Eraser tool~~ to GPv3: Soft mode for the Eraser tool

2023-07-21 13:00:38 +02:00

Amélie Fondevilla force-pushed gpv3-erase-operator-soft-mode from 9945798049 to 01e3378a1a

2023-08-03 10:39:22 +02:00

Compare

Amélie Fondevilla force-pushed gpv3-erase-operator-soft-mode from 01e3378a1a to 6d78ae7632

2023-08-07 12:52:53 +02:00

Compare

Amélie Fondevilla force-pushed gpv3-erase-operator-soft-mode from 6d78ae7632 to 822a302812

2023-08-07 15:37:51 +02:00

Compare

casey-bianco-davis reviewed 2023-08-14 04:47:28 +02:00

source/blender/editors/sculpt_paint/grease_pencil_erase.cc Outdated

						
				@ -577,0 +648,4 @@

				      for (const int src_point : src_points) {

				        src_remove_point[src_point] = (src_new_opacity[src_point] < opacity_threshold);

				      }

				    });

casey-bianco-davis commented

2023-08-14 04:47:28 +02:00

Maybe this could be split into a CurvesGeometry function that takes a IndexMask and handles the point deleting and the topological changes, and soft_eraser only needs to handle the opacity.
something like

IndexMaskMemory memory;
IndexMask points_to_delete = IndexMask::from_bools(src_remove_point, memory);

dst = delete_points(src, points_to_delete);

Maybe this could be split into a `CurvesGeometry` function that takes a `IndexMask` and handles the point deleting and the topological changes, and `soft_eraser` only needs to handle the opacity. something like ``` IndexMaskMemory memory; IndexMask points_to_delete = IndexMask::from_bools(src_remove_point, memory); dst = delete_points(src, points_to_delete); ```

Amélie Fondevilla commented

2023-08-14 09:08:09 +02:00

Yes, that is one idea I have for refactoring the eraser in all modes. Right now, this PR is still pending because we would like to improve a bit the behavior of the soft eraser, so that it inserts points to respect at best the falloff and the radius of the brush tool.
The thing is, if we want to both insert and remove points, it would be best to do it in one pass, because we are going to re-build a new CurvesGeometry in both cases. So maybe this function would be more like dst = insert_and_delete(src, points_to_delete, points_to_insert) (or something similar).
I agree with you that this is going to need a refactor, with the hard eraser mode as well.

Yes, that is one idea I have for refactoring the eraser in all modes. Right now, this PR is still pending because we would like to improve a bit the behavior of the soft eraser, so that it inserts points to respect at best the falloff and the radius of the brush tool. The thing is, if we want to both insert and remove points, it would be best to do it in one pass, because we are going to re-build a new CurvesGeometry in both cases. So maybe this function would be more like `dst = insert_and_delete(src, points_to_delete, points_to_insert)` (or something similar). I agree with you that this is going to need a refactor, with the hard eraser mode as well.

casey-bianco-davis marked this conversation as resolved

Amélie Fondevilla force-pushed gpv3-erase-operator-soft-mode from 822a302812 to 858b552edd

2023-08-14 10:53:20 +02:00

Compare

Amélie Fondevilla force-pushed gpv3-erase-operator-soft-mode from 858b552edd to 94ec1fae71

2023-08-16 14:38:04 +02:00

Compare

Amélie Fondevilla force-pushed gpv3-erase-operator-soft-mode from 94ec1fae71 to a45ba83bab

2023-08-22 16:01:55 +02:00

Compare

Amélie Fondevilla added a new dependency 2023-08-22 16:12:31 +02:00

#111390 GPv3: Refactor code for the hard eraser