WIP: Cycles: Implement BSDF layering #110444

Lukas Stockner · 2023-07-25T04:06:20+02:00

Lukas Stockner commented

2023-07-25 04:06:20 +02:00

Depends on #110443, so ignore the first commit.

The second commit implements the layer() function of OSL, which is a) needed for the Principled BSDF changes and b) good to have in general for e.g. MaterialX.

The third commit implements a "Layer BSDF" node, similar to the Mix and Add nodes, and adds the SVM logic to make it work. In OSL mode, it just uses layer().
With this one, I'm not sure yet - having a general node for layering is one approach, but since only a handful of BSDFs would support acting as the top layer (notably Glass and Sheen), it might make more sense to instead add an optional BSDF input to those nodes instead. That would also be cleaner as far as the SVM compiler/execution is concerned (just give them a hidden output for base weight and hook that up to the SVM Mix Weight input of whatever is connected to the input).

Depends on #110443, so ignore the first commit. The second commit implements the `layer()` function of OSL, which is a) needed for the Principled BSDF changes and b) good to have in general for e.g. MaterialX. The third commit implements a "Layer BSDF" node, similar to the Mix and Add nodes, and adds the SVM logic to make it work. In OSL mode, it just uses `layer()`. With this one, I'm not sure yet - having a general node for layering is one approach, but since only a handful of BSDFs would support acting as the top layer (notably Glass and Sheen), it might make more sense to instead add an optional BSDF input to those nodes instead. That would also be cleaner as far as the SVM compiler/execution is concerned (just give them a hidden output for base weight and hook that up to the SVM Mix Weight input of whatever is connected to the input).

👍 5 👀 3 🎉 2

Lukas Stockner added 3 commits 2023-07-25 04:06:29 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

2931602812 Cycles: Cleanup: Move SVM execution state into a helper struct

This way we don't have to pass the offset all over the place, and
adding additional state (e.g. for layering in the future) becomes
easier.

4605b3a77f Implement layer() in OSL

68ea681777 Implement Layer BSDF node

Lukas Stockner added this to the Render & Cycles project 2023-07-25 04:06:38 +02:00

Lukas Stockner added the

Module

Render & Cycles

label 2023-07-25 04:06:46 +02:00

Brecht Van Lommel commented

2023-11-03 16:38:13 +01:00

Layering support was added in another PR. There is no layer node yet, but we agreed to instead add closure inputs to BSDF nodes that support layering.

Brecht Van Lommel closed this pull request

2023-11-03 16:38:15 +01:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

WIP: Cycles: Implement BSDF layering #110444

Pull request closed