Fix #110415: Interpolate Curves node for single points curves #110477

Merged
Jacques Lucke merged 2 commits from mod_moder/blender:tmp_single_point_curve_fix into blender-v4.0-release 2023-10-19 10:41:41 +02:00

Single point curves should be handled separately.
Previously it was not safe and cause a crash.
Just fill in all dst data one point as full curve.

Single point curves should be handled separately. Previously it was not safe and cause a crash. Just fill in all dst data one point as full curve.
Iliya Katushenock added the
Interest
Geometry Nodes
label 2023-07-25 21:50:25 +02:00
Iliya Katushenock added this to the Nodes & Physics project 2023-07-25 21:50:39 +02:00
Iliya Katushenock requested review from Jacques Lucke 2023-07-25 21:50:49 +02:00
Jacques Lucke reviewed 2023-07-26 15:26:31 +02:00
@ -390,0 +393,4 @@
if (!is_same_up_vector) {
rotated_relative = normal_rotation * rotated_relative;
}
child_positions.fill(rotated_relative);
Member

This does feel a bit wrong. It's not really "relative" to the root.
Also this doesn't take the neighbor_weight into account at all. How are you testing this?

This does feel a bit wrong. It's not really "relative" to the root. Also this doesn't take the `neighbor_weight` into account at all. How are you testing this?
Author
Member

Ah, I did fill the relative values, instead of added it! Yes, I was very inattentive...
Basically I just make sure it didn't crash. Yes, I'll make a simplified example file to test and attach it...

Ah, I did fill the relative values, instead of added it! Yes, I was very inattentive... Basically I just make sure it didn't crash. Yes, I'll make a simplified example file to test and attach it...
mod_moder marked this conversation as resolved
Iliya Katushenock reopened this pull request 2023-10-17 17:02:28 +02:00
Jacques Lucke approved these changes 2023-10-18 11:12:37 +02:00
Jacques Lucke left a comment
Member

Thanks. Looks good now, can you rebase this to the release branch?

Thanks. Looks good now, can you rebase this to the release branch?
Author
Member

Will do later today

Will do later today
Iliya Katushenock changed title from Fix #110415: Interpolate Curves node for single points curves to Fix #110415: Interpolate Curves node for single points curves 2023-10-18 19:04:18 +02:00
Iliya Katushenock force-pushed tmp_single_point_curve_fix from ca89306906 to 2842ca99a4 2023-10-18 19:04:27 +02:00 Compare
Iliya Katushenock changed title from Fix #110415: Interpolate Curves node for single points curves to Fix #110415: Interpolate Curves node for single points curves 2023-10-18 19:20:09 +02:00
Iliya Katushenock changed target branch from main to blender-v4.0-release 2023-10-18 19:20:11 +02:00
Jacques Lucke merged commit e6a0b4404c into blender-v4.0-release 2023-10-19 10:41:41 +02:00
Iliya Katushenock deleted branch tmp_single_point_curve_fix 2023-10-19 13:27:57 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#110477
No description provided.