Geometry Nodes: extract bake items from simulation baking #110577

Jacques Lucke · 2023-07-28T14:32:29+02:00

Jacques Lucke commented

2023-07-28 14:32:29 +02:00

The goal is to reuse the same bake items for simulation and normal baking (#110137). Previously, the bake data was tied to a simulation state which made it harder to reuse.

Now the code for the following things can be reused easily:

Convert geometry node socket values into bake items and back.
Serialize and deserialize bake items.

The goal is to reuse the same bake items for simulation and normal baking (#110137). Previously, the bake data was tied to a simulation state which made it harder to reuse. Now the code for the following things can be reused easily: - Convert geometry node socket values into bake items and back. - Serialize and deserialize bake items.

Jacques Lucke added 1 commit 2023-07-28 14:32:39 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

f010736495 extract bake items storage

Jacques Lucke commented

2023-07-28 14:32:47 +02:00

@blender-bot build

Jacques Lucke requested review from Hans Goudey 2023-07-28 14:33:07 +02:00

Hans Goudey approved these changes 2023-07-28 18:21:17 +02:00

Hans Goudey left a comment

In chat I mentioned it might be nice to have a namespace for the bake stuff beyond blender::bke. blender::bke::bake might work fine, though it could be confused with other things. No real strong opinion though. Otherwise this looks straightforward, just shuffling around code and adding comments, which is nice.

In chat I mentioned it might be nice to have a namespace for the bake stuff beyond `blender::bke`. `blender::bke::bake` might work fine, though it could be confused with other things. No real strong opinion though. Otherwise this looks straightforward, just shuffling around code and adding comments, which is nice.

source/blender/blenkernel/BKE_bake_items_socket.hh Outdated

						
				@ -0,0 +35,4 @@

				 * Create new bake items from the socket values. The socket values are not destructed, but they may

				 * be in a moved-from state afterwards.

				 */

				Vector<std::unique_ptr<BakeItem>> move_socket_values_to_bake_items(Span<void *> socket_values,

Hans Goudey commented

2023-07-28 18:18:34 +02:00

Might as well return an Array here I guess?

Might as well return an `Array` here I guess?

source/blender/blenkernel/BKE_bake_items_socket.hh Outdated

						
				@ -0,0 +44,4 @@

				 *   should only be used when the bake items are not needed afterwards anymore.

				 * - If a socket does not have a corresponding bake item, it's initialized to its default value.

				 *

				 * \param make_attribute_field A function that creates a field input for any anonymous attributes