blender/blender

I18n: translate Repeat Zone in the Add Node menu #110644

Merged

Bastien Montagne merged 1 commits from pioverfour/blender:dp_translate_repeat_zone into main

2023-08-01 18:07:38 +02:00

Damien Picard commented

2023-07-31 03:51:18 +02:00

Member

The Repeat Zone operator from the Geometry nodes Add Node -> Utilities
menu was not translated because it used the "Operator" translation
context, instead of the default context.

Since the function displaying the menu item, add_repeat_zone(), is
only ever called from the Utilities menu, and the label is specified
there as "Repeat Zone", we know in advance that it will have this
name.

For the same reason, this commit also simplifies the function which
creates the menu entry for simulation zones. This function is also
only called from the Simulation menu with a specific label using the
default context, so it should also use this one.

The Repeat Zone operator from the Geometry nodes Add Node -> Utilities menu was not translated because it used the "Operator" translation context, instead of the default context. Since the function displaying the menu item, `add_repeat_zone()`, is only ever called from the Utilities menu, and the label is specified there as "Repeat Zone", we know in advance that it will have this name. For the same reason, this commit also simplifies the function which creates the menu entry for simulation zones. This function is also only called from the Simulation menu with a specific label using the default context, so it should also use this one.

Damien Picard added the

labels 2023-07-31 03:51:19 +02:00

Damien Picard requested review from Bastien Montagne 2023-07-31 03:51:33 +02:00

Bastien Montagne commented

2023-07-31 16:47:52 +02:00

Owner

I guess the operator context is wrong because the given label is never the name of an operator, but the name of a data (the node type)?

But then, how can you be sure that the default context is always the right one here? Commit message could be a bit more explanatory here. :)

I guess the `operator` context is wrong because the given label is never the name of an operator, but the name of a data (the node type)? But then, how can you be sure that the default context is always the right one here? Commit message could be a bit more explanatory here. :)

Damien Picard commented

2023-07-31 17:04:52 +02:00

Author

Member

I guess the operator context is wrong because the given label is never the name of an operator, but the name of a data (the node type)?

Really it’s neither the operator nor data, it’s the UI label specified from the calling menu, NODE_MT_category_GEO_UTILITIES:

        node_add_menu.add_repeat_zone(layout, label="Repeat Zone")

But then, how can you be sure that the default context is always the right one here?

This function, add_repeat_zone(), is only ever called from the utilities menu, so we know in advance that it will always be named "Repeat Zone" (and "Simulation Zone" for the Simulation menu). Of course the function could be called from somewhere else in the future, but even then a label would still likely be passed manually since there is no default value for the label argument, and then Operator would probably not be the right context.

Commit message could be a bit more explanatory here. :)

Will edit, thanks!

> I guess the `operator` context is wrong because the given label is never the name of an operator, but the name of a data (the node type)? Really it’s neither the operator nor data, it’s the UI label specified from the calling menu, `NODE_MT_category_GEO_UTILITIES`: ```python node_add_menu.add_repeat_zone(layout, label="Repeat Zone") ``` > But then, how can you be sure that the default context is always the right one here? This function, `add_repeat_zone()`, is only ever called from the utilities menu, so we know in advance that it will always be named "Repeat Zone" (and "Simulation Zone" for the Simulation menu). Of course the function could be called from somewhere else in the future, but even then a label would still likely be passed manually since there is no default value for the `label` argument, and then `Operator` would probably not be the right context. > Commit message could be a bit more explanatory here. :) Will edit, thanks!

Bastien Montagne commented

2023-08-01 15:05:36 +02:00

Owner

Sounds good, can you then force-push the commit itself? that way I can fast-forward merge, instead of creating a squash commit for the PR?

Sounds good, can you then force-push the commit itself? that way I can fast-forward merge, instead of creating a squash commit for the PR?

Bastien Montagne approved these changes 2023-08-01 15:05:47 +02:00

Damien Picard force-pushed dp_translate_repeat_zone from 71864ccdfe to 93de4ccdee

2023-08-01 17:28:31 +02:00

Compare

Bastien Montagne merged commit c6118da243 into main

2023-08-01 18:07:38 +02:00

Bastien Montagne referenced this issue from a commit

2023-08-01 18:07:38 +02:00

I18n: translate Repeat Zone in the Add Node menu

Bastien Montagne deleted branch dp_translate_repeat_zone

2023-08-01 18:07:39 +02:00

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Automated Testing

Blender Asset Bundle

Code Documentation

Dependency Graph

Development Management

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Viewport & EEVEE

Virtual Reality

Asset Browser Project

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Viewport & EEVEE

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#110644

No description provided.