UI: Rewrite Move to Collection menu #110667

Guillermo Venegas · 2023-08-01T04:19:25+02:00

Guillermo Venegas commented

2023-08-01 04:19:25 +02:00

The code with which the move_to_collection operator menu is created is
simplified.

There are several user-visible changes (see #110667 (comment)):

Each sub menu will first draw the collection to which it belongs, then
the button to create a new child collection, and finally the childs collections.
Before the button to create a new child collection was first and second the
button for the collection itself, this way is hard to recognize that the sub menu
belongs to the collection.
Every collection will have a submenu, in order to be able to select the
collection or create a new collection from it.
The collection_index parameter is replaced by the collection
parameter, this simplifies the use of the operator since it is easier to access
a collection by its name rather than by an index that is not very clear how to
get outside the apy, now the apy allows to move/link any object to any collection in the
current file.
Added a operator paramether scene, that uses the scene master collection to move the objects.

On the developer side, the static pointer master_collection_menu is removed,
this variable points to dynamic allocated memory, which is not always freed.
Without this change, when exiting, blender can report the use memory that was
not freed. Removing this variable reduces the chances of taking this leak as
mismanaged memory elsewhere.

The code with which the `move_to_collection` operator menu is created is simplified. There are several user-visible changes (see https://projects.blender.org/blender/blender/pulls/110667#issuecomment-990158): 1. Each sub menu will first draw the `collection` to which it belongs, then the button to create a `new child collection`, and finally the `childs collections`. Before the button to create a `new child collection` was first and second the button for the `collection` itself, this way is hard to recognize that the sub menu belongs to the `collection`. 2. Every collection will have a submenu, in order to be able to select the collection or create a new collection from it. 3. The `collection_index` parameter is replaced by the `collection` parameter, this simplifies the use of the operator since it is easier to access a collection by its name rather than by an index that is not very clear how to get outside the apy, now the apy allows to move/link any object to any collection in the current file. 4. Added a operator paramether `scene`, that uses the scene master collection to move the objects. On the developer side, the static pointer `master_collection_menu` is removed, this variable points to dynamic allocated memory, which is not always freed. Without this change, when exiting, blender can report the use memory that was not freed. Removing this variable reduces the chances of taking this leak as mismanaged memory elsewhere.

👍 2 🎉 2

Guillermo Venegas added 1 commit 2023-08-01 04:19:33 +02:00

7878f69bda changes

Guillermo Venegas commented

2023-08-01 04:25:07 +02:00

Visible changes:

Before	After(New collection as last option)	After(New collection as Second option)

Visible changes: | Before | After(New collection as last option) | After(New collection as Second option)| | ----------- | ----------- | ----------- | | ![image](/attachments/299ce2bc-47a1-4a74-b831-5a886c1f30e2) | ![image](/attachments/3888b762-6b82-418c-aba7-9c474626e68e) |![image](/attachments/96bb2d17-329a-4c34-8cd5-890d5bc07a39)|

image.png

527 KiB

image.png

497 KiB

image.png

505 KiB

❤️ 3

Iliya Katushenock added the

Module

User Interface

label 2023-08-01 12:33:05 +02:00

Guillermo Venegas added 1 commit 2023-08-01 17:05:50 +02:00

4653337952 cleanup

Guillermo Venegas added 1 commit 2023-08-01 20:17:00 +02:00

05cdf6d0db Merge remote-tracking branch 'origin' into move-to-collection

Guillermo Venegas force-pushed move-to-collection from dd7ad44d69 to 12781e066b

2023-08-02 05:00:21 +02:00

Compare

Guillermo Venegas added 1 commit 2023-08-02 05:04:04 +02:00

f116e903c2 make format

Guillermo Venegas added 1 commit 2023-08-02 05:07:50 +02:00

0b6c8d80b5 fix typo

Guillermo Venegas added 1 commit 2023-08-02 21:47:10 +02:00

284498804c use EnumPropertyItem as paramether instead of string

Guillermo Venegas added 2 commits 2023-08-02 22:09:10 +02:00

1d9062cfa8 Fix name

270aae00d4 Merge remote-tracking branch 'origin/main' into move-to-collection

Guillermo Venegas added 1 commit 2023-08-02 22:14:06 +02:00

ee14d4ef24 fix prop not set

Guillermo Venegas added 1 commit 2023-08-02 22:14:48 +02:00

763627f224 make format

Guillermo Venegas added 1 commit 2023-08-02 22:23:15 +02:00

657088ba72 add mising change

hamza.SMA commented

2023-08-06 01:05:48 +02:00

First-time contributor

hi, IMHO i want to mention that "new collection" must be close to the flesh, because we want to create new collection and we often have many collections in the list so it's hard to go every time to it, i prefer to have it the second below the scene collection then the existed collections ....

a question, especially GPencil, we create many new layers so having 'new layer' in bottom is a bad choice... so maybe the same here? and will this going to affect GPencil layers?

hi, IMHO i want to mention that "new collection" must be close to the flesh, because we want to create new collection and we often have many collections in the list so it's hard to go every time to it, i prefer to have it the second below the scene collection then the existed collections .... a question, especially GPencil, we create many new layers so having 'new layer' in bottom is a bad choice... so maybe the same here? and will this going to affect GPencil layers?

👍 1

Guillermo Venegas added 2 commits 2023-08-11 23:05:18 +02:00

52b9682f90 Merge remote-tracking branch 'origin/main' into move-to-collection

21d0a32ce7 allow move to scenes master collections

Guillermo Venegas added 1 commit 2023-08-11 23:05:37 +02:00

ca0124ad2d Merge remote-tracking branch 'origin/main' into move-to-collection

Guillermo Venegas commented

2023-08-11 23:13:38 +02:00

a question, especially GPencil, we create many new layers so having 'new layer' in bottom is a bad choice.

@hamza-el-barmaki I moved in this pr New Collection as the second option in menus, I see it reasonable, but it would be better if someone from ui says something about it. And for GPencil new layers, would be another pr

> a question, especially GPencil, we create many new layers so having 'new layer' in bottom is a bad choice. @hamza-el-barmaki I moved in this pr New Collection as the second option in menus, I see it reasonable, but it would be better if someone from ui says something about it. And for GPencil new layers, would be another pr

Guillermo Venegas added 2 commits 2023-09-11 18:07:13 +02:00

3b8a3912af Merge remote-tracking branch 'origin/main' into move-to-collection

c361e69cdb resolve conflicts

Guillermo Venegas added 1 commit 2023-09-21 04:34:36 +02:00

cf15df9eb5 init

Guillermo Venegas added 1 commit 2023-09-21 04:39:32 +02:00

169307c9fe undo last commit

Merge conflict checking is in progress. Try again in few moments.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u move-to-collection:guishe-move-to-collection

git checkout guishe-move-to-collection

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

UI: Rewrite Move to Collection menu #110667

Checkout