Fix #110632: temp context doesn't always restore original area or region at exit. #110787

Bastien Montagne · 2023-08-04T10:56:20+02:00

Bastien Montagne commented

2023-08-04 10:56:20 +02:00

Why exactly not explicitely restoring the context with cxt_init
values leaves relevant values to null is unclear to me? But this patch
seems to fix it, by considering that if a temp context value is set,
then it needs to be restored from the init value at the end, even if
both init and temp values are the same.

Why exactly not explicitely restoring the context with `cxt_init` values leaves relevant values to null is unclear to me? But this patch seems to fix it, by considering that if a temp context value is set, then it needs to be restored from the init value at the end, even if both init and temp values are the same.

Bastien Montagne added 1 commit 2023-08-04 10:56:31 +02:00

a78e40bd3b Fix #110632 : temp context doesn't always restore original area or region at exit.

Why exactly not explicitely restoring the context with `cxt_init`
values leaves relevant values to null is unclear to me? But this patch
seems to fix it, by considering that if a temp context value is set,
then it needs to be restored from the init value at the end, even if
both init and temp values are the same.

Bastien Montagne commented

2023-08-04 10:57:26 +02:00

@ideasman42 would love to summon you on this one. ;)

I suspect you'd understand why restoring context area etc. is needed, even when temp values are the same as init ones?

@ideasman42 would love to summon you on this one. ;) I suspect you'd understand why restoring context area etc. is needed, even when temp values are the same as init ones?

Bastien Montagne requested review from Campbell Barton 2023-08-04 12:10:37 +02:00

Campbell Barton commented

2023-08-09 08:58:55 +02:00

@mont29 thanks for looking into this, I dug into the problem and there was in fact another related problem that #110632 didn't cover.
Committed a fix to resolve both with some explanation for whats going on: 0df7d100a3

As it happens this didn't show up in testing because overrides worked as long as the overrides were changing the context, the problems only show up when overriding a value to it's self.

@mont29 thanks for looking into this, I dug into the problem and there was in fact another related problem that #110632 didn't cover. Committed a fix to resolve both with some explanation for whats going on: 0df7d100a3befd44c7ed4c0217690c0eb1245746 As it happens this didn't show up in testing because overrides worked as long as the overrides were changing the context, the problems only show up when overriding a value to it's self.

👍 2

Campbell Barton closed this pull request

2023-08-09 08:58:56 +02:00

Bastien Montagne deleted branch F-110632

2023-08-09 09:53:49 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #110632: temp context doesn't always restore original area or region at exit. #110787

Pull request closed