GPU: Add Dummy Backend For Unsupported Platforms #110919

Merged
Jeroen Bakker merged 10 commits from Jeroen-Bakker/blender:gpu/dummy-backend into main 2023-08-15 14:15:18 +02:00
Member

With the introduction of metal and vulkan we use a different
GPU backend selection which broke the dialog box for unsupported
platforms.

Blender asserted and segfaulted before the dialog was being shown
to the user.

This patch solves this by introducing a dummy GPU backend in case no
GPU backend was supported by OpenGL, Metal and Vulkan Backend.

It also adds the showMessageBox to GHOST_SystemCocoa.

image

Related to #110335

With the introduction of metal and vulkan we use a different GPU backend selection which broke the dialog box for unsupported platforms. Blender asserted and segfaulted before the dialog was being shown to the user. This patch solves this by introducing a dummy GPU backend in case no GPU backend was supported by OpenGL, Metal and Vulkan Backend. It also adds the showMessageBox to GHOST_SystemCocoa. ![image](/attachments/70edc2ce-d3f8-48c7-9657-ceb4d4488e4c) Related to #110335
Jeroen Bakker added this to the 4.0 milestone 2023-08-08 11:30:00 +02:00
Jeroen Bakker self-assigned this 2023-08-08 11:30:00 +02:00
Jeroen Bakker added 1 commit 2023-08-08 11:30:12 +02:00
9b9a36e48b GPU: Add Dummy Backend For Unsupported Platforms
With the introduction of metal and vulkan we use a different
GPU backend selection which broke the dialog box for unsupported
platforms.

Blender asserted and segfaulted before the dialog was being shown
to the user.

This patch solves this by introducing a dummy GPU backend in case no
GPU backend was supported by OpenGL, Metal and Vulkan Backend.
Jeroen Bakker added this to the EEVEE & Viewport project 2023-08-08 11:30:42 +02:00
Jeroen Bakker changed title from GPU: Add Dummy Backend For Unsupported Platforms to DRAFT: GPU: Add Dummy Backend For Unsupported Platforms 2023-08-08 11:31:16 +02:00
Jeroen Bakker changed title from DRAFT: GPU: Add Dummy Backend For Unsupported Platforms to WIP: GPU: Add Dummy Backend For Unsupported Platforms 2023-08-08 11:31:35 +02:00
Jeroen Bakker added 2 commits 2023-08-08 11:36:04 +02:00
Jeroen Bakker added 1 commit 2023-08-08 11:37:11 +02:00
buildbot/vexp-code-patch-coordinator Build done. Details
cdbae69276
Remove debug code.
Author
Member

@blender-bot build

@blender-bot build
Jeroen Bakker changed title from WIP: GPU: Add Dummy Backend For Unsupported Platforms to GPU: Add Dummy Backend For Unsupported Platforms 2023-08-08 12:24:54 +02:00
Jeroen Bakker requested review from Clément Foucault 2023-08-08 12:25:12 +02:00
Author
Member

Moving the popup dialog to a different location doesn't work for all platforms as they might requires a window handle.
I tested linux, Windows and Mac will be tested later this week

Moving the popup dialog to a different location doesn't work for all platforms as they might requires a window handle. I tested linux, Windows and Mac will be tested later this week
Jeroen Bakker added 1 commit 2023-08-10 14:54:17 +02:00
buildbot/vexp-code-patch-coordinator Build done. Details
6fc0a3cb1c
Add message box for macos
Author
Member

@blender-bot build

@blender-bot build
Jeroen Bakker added 1 commit 2023-08-10 15:06:12 +02:00
buildbot/vexp-code-patch-coordinator Build done. Details
fab9fde12c
Equalize logic with linux and windows.
Author
Member

@blender-bot build

@blender-bot build
Jeroen Bakker requested review from Brecht Van Lommel 2023-08-10 21:43:08 +02:00
Author
Member

@brecht I checked with Michael about the changes in https://projects.blender.org/blender/blender/pulls/110919/files#diff-a00214318c9ebfd74806ec588bf97a325bddca1c

Just making sure to get your input on GHOST_SystemCocoa as it isn't a place I normally touch the code.

@brecht I checked with Michael about the changes in https://projects.blender.org/blender/blender/pulls/110919/files#diff-a00214318c9ebfd74806ec588bf97a325bddca1c Just making sure to get your input on GHOST_SystemCocoa as it isn't a place I normally touch the code.
Brecht Van Lommel requested changes 2023-08-11 12:27:11 +02:00
Brecht Van Lommel left a comment
Owner

"Newer graphics drivers may be available to improve Blender support" is not really a thing on macOS. It's more "Upgrading to the latest macOS version may improve Blender support"

"Newer graphics drivers may be available to improve Blender support" is not really a thing on macOS. It's more "Upgrading to the latest macOS version may improve Blender support"
@ -2016,0 +2022,4 @@
GHOST_DialogOptions dialog_options) const
{
@autoreleasepool {
NSAlert *alert = [[[NSAlert alloc] init] autorelease];

Nitpicky, but can we make this dialog a bit wider?
https://stackoverflow.com/a/26502127

Nitpicky, but can we make this dialog a bit wider? https://stackoverflow.com/a/26502127
Jeroen-Bakker marked this conversation as resolved
Jeroen Bakker added 1 commit 2023-08-11 12:56:24 +02:00
Brecht Van Lommel approved these changes 2023-08-11 13:10:07 +02:00
Jeroen Bakker added 1 commit 2023-08-11 14:38:37 +02:00
buildbot/vexp-code-patch-coordinator Build done. Details
0024885fa3
Merge branch 'main' into gpu/dummy-backend
Clément Foucault requested changes 2023-08-14 23:23:15 +02:00
@ -2590,3 +2590,2 @@
config.pszContent = message_16;
config.pButtons = (link) ? buttons : buttons + 1;
config.cButtons = (link) ? 2 : 1;
config.pButtons = strlen(link) ? buttons : buttons + 1;

link is documented as being optional so I would still check for nullptr before strlen.

`link` is documented as being optional so I would still check for nullptr before strlen.
Jeroen-Bakker marked this conversation as resolved
Author
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR110919) when ready.
Jeroen Bakker added 1 commit 2023-08-15 07:59:34 +02:00
buildbot/vexp-code-patch-coordinator Build done. Details
15b86414d5
Add null check to showMessageBox link parameter
Author
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR110919) when ready.
Author
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR110919) when ready.
Clément Foucault approved these changes 2023-08-15 11:39:58 +02:00
Author
Member

@blender-bot build

@blender-bot build
Jeroen Bakker added 1 commit 2023-08-15 13:42:29 +02:00
buildbot/vexp-code-patch-coordinator Build done. Details
96b72457c7
Merge branch 'main' into gpu/dummy-backend
Jeroen Bakker merged commit dd4ab50065 into main 2023-08-15 14:15:18 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#110919
No description provided.