blender-v3.6-release backports #110954

Philipp Oeser · 2023-08-09T14:07:56+02:00

Philipp Oeser commented

2023-08-09 14:07:56 +02:00

No response

_No response_

Philipp Oeser added 6 commits 2023-08-09 14:08:11 +02:00

bc486302fe Fix #99569 : Socket type drawing of custom type in view template

Socket type drawing of custom type in view template.

Pull Request: #109871

ea8f8fd50a Fix #109630 : Grave and Single Quote keys not being detected on MacOS

The `UCKeyTranslate` function was being used wrong.

The `deadKeyState` param should use `kUCKeyTranslateNoDeadKeysMask`
instead of `kUCKeyTranslateNoDeadKeysBit` (optionally could also use
`(1 << kUCKeyTranslateNoDeadKeysBit`)).

This commit also dispenses with accessing the keyAction, as this is not
crucial for determining the key.

Comments have also been added to better describe the code.

Pull Request: #109987

0a10b8e82a Fix #109986 : Crash when using GP grab tool on object with Subdivide modifier

The grab tool could crash when applied to a Grease Pencil object with a
Subdivide modifier (or any other modifier that changes the number of
points in strokes). This patch prevents the grab tool from crashing.

- Removed a grab tool exception that was no longer necessary.
- Added a missing null check.

Pull Request: #110078

4bb2402172 Fix #110107 : Subdivide curves crash with empty input

a30bcc806d Fix #110021 : Deform modifier binding can go wrong in certain stacks

This affected `Mesh Deform`, `Corrective Smooth` and `Laplacian Smooth`.

Exposed by 57ea827bfb (e5ec04d73c).

Evaluating the incoming mesh can be different in
`BKE_object_handle_data_update` as opposed to
`object_force_modifier_update_for_bind` due to different
`CustomData_MeshMasks` being used (the former used a handpicked set, the
later was still using `CD_MASK_BAREMESH`). But since moving many
relevant [to modifiers] data to attributes, this could lead to binding go
wrong (e.g. reporting a vertex count mismatch as reported in #110021
which was due to the fact that creases were not propagated and that
changed the output [also vertex count] of a subdivision modifier in the
stack).

Now use `CD_MASK_DERIVEDMESH` in `object_force_modifier_update_for_bind`
to get all relevant attributes for evaluation (this is not used in `BKE_object_handle_data_update`
to avoid a big performance impact there).

Also fixes #109626 afaict.

Should probably go into 3.6 LTS (maybe even 3.3 LTS).

Pull Request: #110095

buildbot/vexp-code-patch-coordinator Build done. Details

273ba74fcb Paint: Fix drawing delay bug with paint modes

The paint code doesn't invoke `stroke->redraw`
on `INBETWEEN_MOUSEMOVE` events.  This causes
drawing lag on devices that tends to generate
more of them, like pen tablets.

The code no longer does this.  It does still exclude
inbetween events for updating the paint cursor.

I checked, and only the two paint modes (3d texture paint and image paint) actually
use `stroke->redraw`.  Both are implemented to only draw when necessary:

* `paint_2d_redraw` checks for `.need_redraw` flag on tiles.
* `paint_proj_redraw` checks `ProjStrokeHandle.need_redraw`.

I believe this may be the cause of #93796

Pull Request: #110119

Philipp Oeser commented

2023-08-09 14:08:35 +02:00

@blender-bot build

Philipp Oeser merged commit 93e71a4ce2 into blender-v3.6-release

2023-08-09 14:29:33 +02:00

Philipp Oeser deleted branch blender-v3.6-release

2023-08-09 14:29:34 +02:00

Philipp Oeser referenced this issue from a commit

2023-08-09 14:29:35 +02:00

Paint: Fix drawing delay bug with paint modes

Sign in to join this conversation.

No reviewers