blender
/
blender
131
398
Fork 577
Code Issues 6.2k Pull Requests 744 Projects 19 Wiki Activity

WIP: Splash Screen Preferences Warning #110978

Closed
Harley Acheson wants to merge 7 commits from Harley/blender:SplashPrefs into main
pull from: Harley/blender:SplashPrefs
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 10 Commits 7 Files Changed 1 +62 -9
Harley Acheson commented 2023-08-09 20:14:41 +02:00
Member
Copy Link

Added warning to Quick Setup because of changed default shortcuts.

This implements the current last suggestion in #110425 found here:
#110425 (comment)

image

One change that is not requested is this PR also turns off the closing of the dialog by clicking the splash image - when in Quick Setup Mode.

Added warning to Quick Setup because of changed default shortcuts. --- This implements the current last suggestion in #110425 found here: https://projects.blender.org/blender/blender/issues/110425#issuecomment-994753 ![image](/attachments/68c222d0-f60c-4c5b-9d23-0a8e10949cde) One change that is not requested is this PR also turns off the closing of the dialog by clicking the splash image - when in Quick Setup Mode.
image.png
403 KiB
image.png
389 KiB
image.png
367 KiB
image.png
355 KiB
image.png
390 KiB
image.png image.png image.png image.png
Harley Acheson added 1 commit 2023-08-09 20:14:51 +02:00
b0629de89d WIP: Splash Screen Preferences Warning 
Added warning to Quick Setup because of changed default shortcuts.
Harley Acheson requested review from Julien Kaspar 2023-08-09 20:15:04 +02:00
Harley Acheson added this to the User Interface project 2023-08-09 20:15:13 +02:00
Julien Kaspar commented 2023-08-09 21:45:57 +02:00
Member
Copy Link

Thanks @Harley !
It should link to this page:
https://wiki.blender.org/wiki/Reference/Release_Notes/4.0/Keymap

Right now each line is a separate operator button. Perhaps it's better as one line?
"This new version of Blender contains new default shortcuts ..."

Then it also takes up just a bit less space.

Thanks @Harley ! It should link to this page: https://wiki.blender.org/wiki/Reference/Release_Notes/4.0/Keymap Right now each line is a separate operator button. Perhaps it's better as one line? "This new version of Blender contains new default shortcuts ..." Then it also takes up just a bit less space.
Harley Acheson commented 2023-08-09 22:30:05 +02:00
Author
Member
Copy Link

Thanks @Harley !

No problem. What I (think) I have learned with this so far....

For me the weight of the warning wasn't strong enough when the size of the icon was smaller, hence the use of the uiDefButAlert icons rather than the normal UI buttons. Unfortunately we don't have access to those from python, so this couldn't just go inside "WM_MT_splash_quick_setup". And also means we have to select from these:

image

Of course if you disagree and want me to show you what it looks like with a regular little UI icon I can certainly do so.

It should link to this page:
https://wiki.blender.org/wiki/Reference/Release_Notes/4.0/Keymap

Perfect. Thanks! Will update the PR shortly-ish.

Right now each line is a separate operator button. Perhaps it's better as one line?
"This new version of Blender contains new default shortcuts ..."

Can try that. You are hoping the ellipsis will indicate that something will happen when you click on it? I worry it will just appear to most uses as truncation of a longer string.

We might be able to stay within a single line and also have a "call to action" by removing some details? Something like "Click here for important details about shortcut changes..."

> Thanks @Harley ! No problem. What I (think) I have learned with this so far.... For me the weight of the warning wasn't strong enough when the size of the icon was smaller, hence the use of the uiDefButAlert icons rather than the normal UI buttons. Unfortunately we don't have access to those from python, so this couldn't just go inside "WM_MT_splash_quick_setup". And also means we have to select from these: ![image](/attachments/8007fb8b-d2a9-42eb-be0c-2c24fde92cb1) Of course if you disagree and want me to show you what it looks like with a regular little UI icon I can certainly do so. > It should link to this page: > https://wiki.blender.org/wiki/Reference/Release_Notes/4.0/Keymap Perfect. Thanks! Will update the PR shortly-ish. > Right now each line is a separate operator button. Perhaps it's better as one line? > "This new version of Blender contains new default shortcuts ..." Can try that. You are hoping the ellipsis will indicate that something will happen when you click on it? I worry it will just appear to most uses as truncation of a longer string. We might be able to stay within a single line and also have a "call to action" by removing some details? Something like "Click here for important details about shortcut changes..."
image.png
44 KiB
Harley Acheson added 1 commit 2023-08-10 00:53:07 +02:00
Harley Acheson commented 2023-08-10 00:55:31 +02:00
Author
Member
Copy Link

@JulienKaspar - I updated the PR to use only a single line of link text and a smaller icon. The image capture in the first comment is updated. Better? Worse?

@JulienKaspar - I updated the PR to use only a single line of link text and a smaller icon. The image capture in the first comment is updated. Better? Worse?
Julien Kaspar commented 2023-08-10 12:01:26 +02:00
Member
Copy Link

@Harley I think it's much better! I agree that the ellipsis might not be enough. Maybe if we rephrase it to something like this:
"New default shortcuts! Click here to read more ...

Keeping it simple and short: "Context. Call to action ..."

We could also try the info icon instead. I actually never saw this one used before in Blender?
It would fit better since the message is aiming to inform, not to alert of an error.

Right now I'm still getting an error when clicking the button.

@Harley I think it's much better! I agree that the ellipsis might not be enough. Maybe if we rephrase it to something like this: "New default shortcuts! Click here to read more ... Keeping it simple and short: "Context. Call to action ..." We could also try the info icon instead. I actually never saw this one used before in Blender? It would fit better since the message is aiming to inform, not to alert of an error. Right now I'm still getting an error when clicking the button.
Harley Acheson commented 2023-08-10 18:53:19 +02:00
Author
Member
Copy Link

@JulienKaspar - We could also try the info icon instead.

The following should show 6 variations, 3 with large icons and 3 with small icons. I think I prefer the large one with the ⚠, but the little "info" one is okay. I'd be fine with whatever you prefer to be honest.

IconsLarge.gif

> @JulienKaspar - We could also try the info icon instead. The following should show 6 variations, 3 with large icons and 3 with small icons. I think I prefer the large one with the ⚠, but the little "info" one is okay. I'd be fine with whatever you prefer to be honest. ![IconsLarge.gif](/attachments/e1f0d64d-297c-4f8b-aedd-bf2dcd60944f)
IconsLarge.gif
607 KiB
Harley Acheson added 1 commit 2023-08-10 19:05:55 +02:00
Harley Acheson commented 2023-08-10 19:09:35 +02:00
Author
Member
Copy Link

@JulienKaspar - Right now I'm still getting an error when clicking the button.

What error? Just in case I did update the PR from the current state of master. But for me clicking on the text gives me a new browser tab with that url.

While in there I changed the text slightly to "Click here for important information about shortcut changes..." with "information" replacing "details".

Also made it so clicking on the icon does the same thing.

Note that I added an animated GIF in a comment above for you to see the differences between the various icon choices.

> @JulienKaspar - Right now I'm still getting an error when clicking the button. What error? Just in case I did update the PR from the current state of master. But for me clicking on the text gives me a new browser tab with that url. While in there I changed the text slightly to "Click here for important information about shortcut changes..." with "information" replacing "details". Also made it so clicking on the icon does the same thing. Note that I added an animated GIF in a comment above for you to see the differences between the various icon choices.
Harley Acheson added 1 commit 2023-08-10 19:31:09 +02:00
Harley Acheson commented 2023-08-10 19:41:43 +02:00
Author
Member
Copy Link

Updated to use @JulienKaspar's current preferred icon (info) and text ("New default shortcuts! Click her to read more...")

Updated to use @JulienKaspar's current preferred icon (info) and text ("New default shortcuts! Click her to read more...")
Julien Kaspar commented 2023-08-11 14:23:47 +02:00
Member
Copy Link

Overall I'm already very happy with the result. It all works for me now.

I chatted with @JulianEisel to get some feedback. We both preferred the big info icon.

He suggested the text to be "Learn more about the Blender 4.0 shortcut changes ..."
I'm ok with that.

He also suggested it's better if the mouse over highlight would be grey and highlight the entire box.
But we can also merge it and tweak the UI as needed afterwards 👍

Overall I'm already very happy with the result. It all works for me now. I chatted with @JulianEisel to get some feedback. We both preferred the big info icon. He suggested the text to be "Learn more about the Blender 4.0 shortcut changes ..." I'm ok with that. He also suggested it's better if the mouse over highlight would be grey and highlight the entire box. But we can also merge it and tweak the UI as needed afterwards 👍
Clipboard - August 11.jpg
864 KiB
Clipboard - August 11.jpg
Harley Acheson added 2 commits 2023-08-11 19:34:05 +02:00
Harley Acheson added 1 commit 2023-08-11 20:10:54 +02:00
Harley Acheson commented 2023-08-17 02:42:19 +02:00
Author
Member
Copy Link

We discussed this in the UI module meeting and weren't liking this approach much. Favoring this alternative, or variation of it: #111123. Or perhaps a third alternative that simplifies the entire thing more.

We discussed this in the UI module meeting and weren't liking this approach much. Favoring this alternative, or variation of it: #111123. Or perhaps a third alternative that simplifies the entire thing more.
Harley Acheson commented 2023-10-06 23:50:18 +02:00
Author
Member
Copy Link

Alternative #111123 has been merged.

Alternative #111123 has been merged.
Harley Acheson closed this pull request 2023-10-06 23:50:20 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Julien Kaspar
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
User Interface
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#110978
No description provided.
Delete Branch "Harley/blender:SplashPrefs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?