Render: Incremental steps to move callbacks to base class methods #111047

Merged

Sergey Sharybin merged 10 commits from Sergey/blender:render_result into main

2023-08-14 11:18:35 +02:00

Sergey Sharybin commented

2023-08-11 14:05:49 +02:00

Owner

Moving forward with making it as easy as possible to have render pipeline to
point to a base class of Render, making it more flexible and easy to operate
in the same way for the final and viewport render.

Additionally, it allows moving towards direction when areas like baking will
sub-class the Render to change its behavior as opposite of the current approach
of doing customization via callbacks.

Moving forward with making it as easy as possible to have render pipeline to point to a base class of Render, making it more flexible and easy to operate in the same way for the final and viewport render. Additionally, it allows moving towards direction when areas like baking will sub-class the Render to change its behavior as opposite of the current approach of doing customization via callbacks. Ref #108618

Sergey Sharybin added the

Render & Cycles

label 2023-08-11 14:05:49 +02:00

Sergey Sharybin added 10 commits 2023-08-11 14:06:02 +02:00

90e16be9d2 Cleanup: Add _cb suffix to the callbacks stored in Render

Should be no functional changes.

Preparing for introduction of member function which are
available in the base class.

668750f7c9 Refactor: Make prepare_viewlayer a base render method

Should be no functional changes.

ea68513141 Refactor: Make test_break a base render method

Should be no functional changes.

7b23ef8a4c Refactor: Make draw_lock a base render method

Also semantically separate draw_lock and draw_unlock, as it
is more clear than a single method with a boolean argument.

Should be no functional changes.

7e192dfdbf Refactor: Make progress a base render method

Should be no functional changes.

a30d42445a Refactor: Make stats_draw a base render method

Should be no functional changes.

78e7791289 Refactor: Make current_scene_update a base render method

Should be no functional changes.

57fc39c5db Refactor: Make display_update a base render method

Should be no functional changes.

a78afdd4c9 Refactor: Make display_clear a base render method

Should be no functional changes.

buildbot/vexp-code-patch-coordinator Build done. Details

1251cd174f Refactor: Make display_init a base render method

Should be no functional changes.

Sergey Sharybin commented

2023-08-11 14:06:14 +02:00

Author

Owner

@blender-bot build

@blender-bot build

Sergey Sharybin requested review from Brecht Van Lommel 2023-08-11 14:36:29 +02:00

Brecht Van Lommel approved these changes 2023-08-11 17:36:14 +02:00

Sergey Sharybin merged commit 9094a3a9ab into main

2023-08-14 11:18:35 +02:00

Sergey Sharybin referenced this issue from a commit

2023-08-14 11:18:36 +02:00

Refactor: Make display_init a base render method

Sergey Sharybin deleted branch render_result

2023-08-14 11:18:36 +02:00

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#111047

No description provided.