Fix #111067: NLA tracks cannot be renamed from Outliner #111110

Merged

Philipp Oeser merged 1 commits from lichtwerk/blender:111067 into main

2023-08-14 15:27:25 +02:00

Philipp Oeser commented

2023-08-14 12:48:54 +02:00

Member

Outliner do_item_rename has checks so linked or overridden IDs cannot
be renamed.

A TreeStoreElems ID can point to other data than "real" IDs though
(see how outliner_add_element casts to an ID from an arbitrary void
pointer and cases marked /* NO ID */ in code). In those cases,
ID_IS_LINKED or ID_IS_OVERRIDE_LIBRARY could return true and a the
renaming operation would fail.

Now also check if this is a real ID (TSE_IS_REAL_ID), so code can
continue.

Also add a proper notifier, so track renaming from the Outliner will
update the NLA immediately.

Outliner `do_item_rename` has checks so linked or overridden IDs cannot be renamed. A `TreeStoreElem`s ID can point to other data than "real" IDs though (see how `outliner_add_element` casts to an ID from an arbitrary void pointer and cases marked `/* NO ID */` in code). In those cases, `ID_IS_LINKED` or `ID_IS_OVERRIDE_LIBRARY` _could_ return true and a the renaming operation would fail. Now also check if this is a real ID (`TSE_IS_REAL_ID`), so code can continue. Also add a proper notifier, so track renaming from the Outliner will update the NLA immediately.

Philipp Oeser added 1 commit 2023-08-14 12:49:07 +02:00

30c2259bcc Fix #111067 : NLA tracks cannot be renamed from outliner

Outliner `do_item_rename` has checks so linked or overridden IDs cannot
be renamed.

A `TreeStoreElem`s ID can point to other data than "real" IDs though
(see how `outliner_add_element` casts to an ID from an arbitrary void
pointer and cases marked `/* NO ID */` in code). In those cases,
`ID_IS_LINKED` or `ID_IS_OVERRIDE_LIBRARY` _could_ return true and a the
renaming operation would fail.

Now also check if this is a real ID (`TSE_IS_REAL_ID`), so code can
continue.

Also add a proper notifier, so track renaming from the Outliner will
update the NLA immediately.

Philipp Oeser added this to the User Interface project 2023-08-14 12:49:30 +02:00

Philipp Oeser added the

Animation & Rigging

labels 2023-08-14 12:50:02 +02:00

Philipp Oeser requested review from Julian Eisel 2023-08-14 12:50:11 +02:00

Philipp Oeser requested review from Bastien Montagne 2023-08-14 12:50:22 +02:00

Julian Eisel approved these changes 2023-08-14 12:51:44 +02:00

Bastien Montagne approved these changes 2023-08-14 14:17:52 +02:00

Bastien Montagne left a comment

Owner

Patch LGTM.

It raises the question of editing non-ID data that should not be editable though? Looks like this function does not take into account fact like 'NLA tracks from linked data should not be renamed' (and probably many more similar cases)?

Patch LGTM. It raises the question of editing non-ID data that should not be editable though? Looks like this function does not take into account fact like 'NLA tracks from linked data should not be renamed' (and probably many more similar cases)?

Philipp Oeser commented

2023-08-14 15:26:54 +02:00

Author

Member

Patch LGTM.

It raises the question of editing non-ID data that should not be editable though? Looks like this function does not take into account fact like 'NLA tracks from linked data should not be renamed' (and probably many more similar cases)?

Will look at that separately

> Patch LGTM. > > It raises the question of editing non-ID data that should not be editable though? Looks like this function does not take into account fact like 'NLA tracks from linked data should not be renamed' (and probably many more similar cases)? Will look at that separately

Philipp Oeser merged commit cf43477839 into main

2023-08-14 15:27:25 +02:00

Philipp Oeser deleted branch 111067

2023-08-14 15:27:27 +02:00

Philipp Oeser referenced this issue from a commit

2023-08-14 15:27:29 +02:00

Fix #111067: NLA tracks cannot be renamed from Outliner

Almaz-Shinbay referenced this issue from a commit

2023-08-14 18:08:03 +02:00

Fix #111067: NLA tracks cannot be renamed from Outliner

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#111110

No description provided.