GPv3: Re-evaluate on frame change #111137

Falk David · 2023-08-15T15:45:03+02:00

Falk David commented

2023-08-15 15:45:03 +02:00

This makes it so the GreasePencil geometry gets updated on a time
change.
The frame at which the object gets evaluated is stored in runtime as
eval_frame. This is for example used to calculate the bounding box
of the geometry as well as invalidating the batch cache for different
frames.

This makes it so the `GreasePencil` geometry gets updated on a time change. The frame at which the object gets evaluated is stored in runtime as `eval_frame`. This is for example used to calculate the bounding box of the geometry as well as invalidating the batch cache for different frames.

Falk David added 1 commit 2023-08-15 15:45:12 +02:00

fd35bd0ffc GPv3: Update on frame change

This makes it so the `GreasePencil` geometry gets updated on a time
change.
The frame at which the object gets evaluated is stored in runtime as
`eval_frame`. This is for example used to calculate the bounding box
of the geometry as well as invalidating the batch cache for different
frames.

Falk David requested review from Sergey Sharybin 2023-08-15 15:45:27 +02:00

Falk David added this to the Grease Pencil project 2023-08-15 15:45:34 +02:00

Falk David added 1 commit 2023-08-15 15:46:08 +02:00

b6150e6642 formatting

Sergey Sharybin reviewed 2023-08-15 16:24:58 +02:00

Sergey Sharybin left a comment

From the depsgraph side the change seems much simpler to what we've discussed here. So that's super nice :)

For the changes outside of the DEG, is something I remember we've also discussed, and from a bigger picture it does seem to make sense. But the details and such you probably have better idea than me looking into this patch :)

From the depsgraph side the change seems much simpler to what we've discussed here. So that's super nice :) For the changes outside of the DEG, is something I remember we've also discussed, and from a bigger picture it does seem to make sense. But the details and such you probably have better idea than me looking into this patch :)

source/blender/blenkernel/intern/grease_pencil.cc

						
				@ -1716,0 +1752,4 @@

				      function(index, drawing->wrap());

				    }

				    else if (drawing_base->type == GP_DRAWING_REFERENCE) {

				      /* TODO */