Vulkan: Report Incompatible Shaders #111138

Jeroen Bakker · 2023-08-15T15:45:53+02:00

Jeroen Bakker commented

2023-08-15 15:45:53 +02:00

A difference was detected between stage interfaces between OpenGL and Vulkan
that are not compatible with our current API.

OpenGL

In OpenGL an stage interface struct can have different interpolation qualifiers
per attribute.

struct MyStageInterface {
    smooth vec4 color;
    flat int face_flag;
};
layout(..) MyStageInterface interp;

Vulkan

In vulkan the interpolation qualifier isn't supported on attribute
level and needs to be added to the struct.

struct MyStageInterface {
    vec4 color;
};
struct MyStageInterface_flat {
    int face_flag;
};
layout(..) smooth MyStageInterface interp;
layout(..) flat MyStageInterface_flat interp_flat;

This patch reports shaders that are incompatible with Vulkan so they can be
patched. Report is only done in debug mode and when using the vulkan backend.
After all shaders are patched an error will be raised so developers will
known immediately when incompatibility are created.

Making the shaders compatible and adding the error will be done in future
patches.

Python

Via Python gpu module (gpu.types.GPUShaderCreateInfo) it isn't possible
to construct an incompatible shader as instance names cannot be set
via the API. So this isn't a breaking change.

A difference was detected between stage interfaces between OpenGL and Vulkan that are not compatible with our current API. **OpenGL** In OpenGL an stage interface struct can have different interpolation qualifiers per attribute. ```glsl struct MyStageInterface { smooth vec4 color; flat int face_flag; }; layout(..) MyStageInterface interp; ``` **Vulkan** In vulkan the interpolation qualifier isn't supported on attribute level and needs to be added to the struct. ```glsl struct MyStageInterface { vec4 color; }; struct MyStageInterface_flat { int face_flag; }; layout(..) smooth MyStageInterface interp; layout(..) flat MyStageInterface_flat interp_flat; ``` This patch reports shaders that are incompatible with Vulkan so they can be patched. Report is only done in debug mode and when using the vulkan backend. After all shaders are patched an error will be raised so developers will known immediately when incompatibility are created. Making the shaders compatible and adding the error will be done in future patches. **Python** Via Python gpu module (gpu.types.GPUShaderCreateInfo) it isn't possible to construct an incompatible shader as instance names cannot be set via the API. So this isn't a breaking change.

Jeroen Bakker added this to the 4.0 milestone 2023-08-15 15:45:53 +02:00

Jeroen Bakker added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Vulkan: Report Incompatible Shaders #111138