Realtime Compositor: Support realization of transformations #111179

Merged

Omar Emara merged 3 commits from OmarEmaraDev/blender:realize-transformations into main

2023-08-18 10:00:25 +02:00

Omar Emara commented

2023-08-16 13:39:01 +02:00

Member

This patch adds support for the realization of transformations of
operation inputs in the Realtime Compositor. Input socket declarations
can now include a preference to what sort of realization needs to
happen.

All inputs specify realization on the operation domain by default
because that is needed for the correct operation of most operations.

Nodes may choose not to be realized on the operation domain, like the
MapUV, Plane Deform, and Bokeh Blur nodes; that's because their inputs
are treated as transform-less image objects.

Nodes may chose to realize their rotation or scale, like operations that
are not rotation or scale invariant and thus need images of identity
transformations. No nodes are declared as such so far, as this is still
being considered by developers and test builds be published for testing.

This patch coincidently also fixes #102252 by declaring the Bokeh input
of the Bokeh Blur node to need realization of rotation.

Depends on #111178.
Fixes #102252.

This patch adds support for the realization of transformations of operation inputs in the Realtime Compositor. Input socket declarations can now include a preference to what sort of realization needs to happen. All inputs specify realization on the operation domain by default because that is needed for the correct operation of most operations. Nodes may choose not to be realized on the operation domain, like the MapUV, Plane Deform, and Bokeh Blur nodes; that's because their inputs are treated as transform-less image objects. Nodes may chose to realize their rotation or scale, like operations that are not rotation or scale invariant and thus need images of identity transformations. No nodes are declared as such so far, as this is still being considered by developers and test builds be published for testing. This patch coincidently also fixes #102252 by declaring the Bokeh input of the Bokeh Blur node to need realization of rotation. Depends on #111178. Fixes #102252.

Omar Emara added the

labels 2023-08-16 13:39:02 +02:00

Omar Emara added 2 commits 2023-08-16 13:39:09 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

61c42b2c74 BLI: Add 2D transformation matrix decomposition

This patch adds support for 2D transformation matrix decomposition into
translation, rotation, and scale. This is needed by the realtime
compositor to implement automatic domain realization logic.

34353ba45d Realtime Compositor: Support realization of transformations

This patch adds support for the realization of transformations of
operation inputs in the Realtime Compositor. Input socket declarations
can now include a preference to what sort of realization needs to
happen.

All inputs specify realization on the operation domain by default
because that is needed for the correct operation of most operations.

Nodes may choose not to be realized on the operation domain, like the
MapUV, Plane Deform, and Bokeh Blur nodes; that's because their inputs
are treated as transform-less image objects.

Nodes may chose to realize their rotation or scale, like operations that
are not rotation or scale invariant and thus need images of identity
transformations. No nodes are declared as such so far, as this is still
being considered by developers and test builds be published for testing.

This patch coincidently also fixes #102252 by declaring the Bokeh input
of the Bokeh Blur node to need realization of rotation.

Depends on #111178.
Fixes #102252.

Omar Emara requested review from Sergey Sharybin 2023-08-16 13:39:42 +02:00

Omar Emara commented

2023-08-16 13:42:05 +02:00

Author

Member

This is preparatory work for supporting automatic realization of rotation and scale in the realtime compositor. Test builds with relevant nodes declaring realization of rotation and scale will be provided based on this patch.

This is preparatory work for supporting automatic realization of rotation and scale in the realtime compositor. Test builds with relevant nodes declaring realization of rotation and scale will be provided based on this patch.

Omar Emara added 1 commit 2023-08-16 14:49:32 +02:00

9a25939c92 Merge branch 'main' into realize-transformations

Omar Emara referenced this pull request

2023-08-17 11:30:12 +02:00

Realtime Compositor: Realize rotation for filter nodes #111213

Omar Emara referenced this pull request

2023-08-17 11:44:02 +02:00

Realtime Compositor: Realize rotation and scale for filter nodes #111216

Sergey Sharybin commented

2023-08-17 14:41:16 +02:00

Owner

I am a bit confused here. Are there expected functional changes already (i.e. in the way how Blur handles realization) or is it a technical aspect of making it possible to do "auto-realization" ?

I am a bit confused here. Are there expected functional changes already (i.e. in the way how Blur handles realization) or is it a technical aspect of making it possible to do "auto-realization" ?

Omar Emara commented

2023-08-17 14:49:17 +02:00

Author

Member

@Sergey The only functional change is that the Bokeh Blur node now realizes the rotation of its Bokeh input, which was done to fix #102252.

#111216 and #111213 are test builds based on this patch to enable realization for relevant nodes.

@Sergey The only functional change is that the Bokeh Blur node now realizes the rotation of its Bokeh input, which was done to fix #102252. #111216 and #111213 are test builds based on this patch to enable realization for relevant nodes.

Sergey Sharybin approved these changes 2023-08-17 15:40:14 +02:00

Sergey Sharybin left a comment

Owner

I see, thanks for the details!
I think the patch is good.

I see, thanks for the details! I think the patch is good.

Omar Emara merged commit 726ba534fc into main

2023-08-18 10:00:25 +02:00

Omar Emara deleted branch realize-transformations

2023-08-18 10:00:27 +02:00

Omar Emara referenced this issue from a commit

2023-08-18 10:00:28 +02:00

Realtime Compositor: Support realization of transformations

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#111179

No description provided.