Cleanup: Anim: Replace use of T_AUTOMERGE #111268

Merged
Falk David merged 2 commits from filedescriptor/blender:cleanup-anim-use-of-automerge-flag into main 2023-09-11 14:43:42 +02:00
Member

In the animation transform code, T_AUTOMERGE was used
to indicate that the duplicated keys need to be merged.

In perparation of #111051, this no longer makes much sense because
in grease pencil we cannot have two keys in the same channel at the same
frame.

This PR replaces the T_AUTOMERGE flag in the animation code to
T_DUPLICATED_KEYS to indicate that the transform is being called
with duplicated keyframes.

In the animation transform code, `T_AUTOMERGE` was used to indicate that the duplicated keys need to be merged. In perparation of #111051, this no longer makes much sense because in grease pencil we cannot have two keys in the same channel at the same frame. This PR replaces the `T_AUTOMERGE` flag in the animation code to `T_DUPLICATED_KEYS` to indicate that the transform is being called with duplicated keyframes.
Falk David added this to the Animation & Rigging project 2023-08-18 15:39:50 +02:00
Falk David requested review from Campbell Barton 2023-08-18 15:39:56 +02:00

In general this seems OK, however I think it can be made more obvious what the flag does.

The name T_DUPLICATED_KEYS feels a bit vague, suggest either:

This could be named generically: e.g. T_DUPLICATED and document this is currently only used for key-frames (the same setting could be used elsewhere in the future).

Otherwise, if you feel this should only be used for animation-editors, I'd prefer T_DUPLICATED_KEYFRAMES to make it clear it's for key-frames and not shape-keys or something else.

Accepting, no extra review needed.

In general this seems OK, however I think it can be made more obvious what the flag does. The name `T_DUPLICATED_KEYS` feels a bit vague, suggest either: This could be named generically: e.g. `T_DUPLICATED` and document this is currently only used for key-frames (the same setting could be used elsewhere in the future). Otherwise, if you feel this should only be used for animation-editors, I'd prefer `T_DUPLICATED_KEYFRAMES` to make it clear it's for key-frames and not shape-keys or something else. Accepting, no extra review needed.
Campbell Barton approved these changes 2023-08-23 08:13:09 +02:00
Campbell Barton approved these changes 2023-08-23 08:13:20 +02:00
Falk David force-pushed cleanup-anim-use-of-automerge-flag from f7b4bced47 to 07a6a1015a 2023-09-11 14:43:19 +02:00 Compare
Falk David merged commit 5ed35e5665 into main 2023-09-11 14:43:42 +02:00
Falk David deleted branch cleanup-anim-use-of-automerge-flag 2023-09-11 14:43:44 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser Project (Legacy)
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#111268
No description provided.