WIP: Fix retiming tool strip length misinterpretation #111307

Jonah Janzen · 2023-08-19T22:47:28+02:00

Jonah Janzen commented

2023-08-19 22:47:28 +02:00

First-time contributor

This is still unfinished, but it will fix #108160.
strip_frame_index in SeqRetimingHandle was off by one, meaning that it was misaligned compared the zero-based indices used elsewhere in the VSE. This caused the displayed speed in the retiming tool to use an incorrectly calculated fraction, which led to a visibly incorrect retime speed in image sequences due to their lower frame count.
It now works properly upon loading a new image sequence, but still breaks after the "Set Speed" dialog is used, presumably because strip_frame_index is still set incorrectly in other places.
@iss If you could confirm that I'm on the right track with this fix, I'll happily complete it, but as I'm not very familiar with the VSE I just want to confirm that this is right.

This is still unfinished, but it will fix #108160. `strip_frame_index` in SeqRetimingHandle was off by one, meaning that it was misaligned compared the zero-based indices used elsewhere in the VSE. This caused the displayed speed in the retiming tool to use an incorrectly calculated fraction, which led to a visibly incorrect retime speed in image sequences due to their lower frame count. It now works properly upon loading a new image sequence, but still breaks after the "Set Speed" dialog is used, presumably because `strip_frame_index` is still set incorrectly in other places. @iss If you could confirm that I'm on the right track with this fix, I'll happily complete it, but as I'm not very familiar with the VSE I just want to confirm that this is right.

Jonah Janzen added 1 commit 2023-08-19 22:47:40 +02:00

c4a45b58b9 Fix retiming tool strip length misinterpretation

strip_frame_index in SeqRetimingHandle was off by one, meaning that it was misaligned with the zero-based indices used elsewhere in the VSE.

Richard Antalik commented

2023-08-23 16:14:06 +02:00

Thanks for patch and sorry for late response. I am not quite sure whether issue was in where the handle is vs where it is drawn - there is exception for last key, since it can not be at the end of number of frames available. But I think I have fixed that at some point...

In any case, I am working on #109044 which does not have this issue.

Thanks for patch and sorry for late response. I am not quite sure whether issue was in where the handle is vs where it is drawn - there is exception for last key, since it can not be at the end of number of frames available. But I think I have fixed that at some point... In any case, I am working on #109044 which does not have this issue.

Jonah Janzen commented

2023-08-25 03:24:52 +02:00

First-time contributor

All right, I'm glad you were already able to fix it! Thanks for letting me know, and I'm sorry about the bother.

Jonah Janzen closed this pull request

2023-08-25 03:24:53 +02:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

WIP: Fix retiming tool strip length misinterpretation #111307

Pull request closed