Fix #97049: Auto-keyframe Status Message Overlaps Navigation Gizmo #111356

Merged
Nate Rupsis merged 5 commits from nrupsis/blender:105565-global_auto_key_overlap into main 2023-08-24 15:25:52 +02:00
Member

Finishing developing / landing #105565


"Auto Keying On" display now respects users MINI_AXIS preferences (default, minimal, none), as well as the navigation (en)disable option. No more text overlapping.

Finishing developing / landing [#105565](https://projects.blender.org/blender/blender/pulls/105565) --- "Auto Keying On" display now respects users MINI_AXIS preferences (default, minimal, none), as well as the navigation (en)disable option. No more text overlapping.
Nate Rupsis added 4 commits 2023-08-21 19:20:42 +02:00
Nate Rupsis requested review from Sybren A. Stüvel 2023-08-21 19:20:52 +02:00
Nate Rupsis requested review from Harley Acheson 2023-08-21 19:21:02 +02:00
Nate Rupsis requested review from Christoph Lendenfeld 2023-08-21 19:21:19 +02:00
Nate Rupsis added the
Module
Animation & Rigging
label 2023-08-21 19:21:28 +02:00
Nate Rupsis added this to the Animation & Rigging project 2023-08-21 19:21:34 +02:00
Member

@nrupsis:

This works quite well. I only see problems in very specific settings, mostly because "Simple Axes" (only) changes its width quite a lot as the "Line Width" is changed. If you change the resolution scale to 2.0, then change the Line Width to "Thick" or "Thin" you will see the text overlapping.

This width change depends on U.pixelsize. Because all the offsets are multiplied by U.scale_factor later, this is as simple of a solution as I could find - and it is not perfect. Close enough?

      case USER_MINI_AXIS_TYPE_MINIMAL:
        offset = U.rvisize * MIN2((U.pixelsize / U.scale_factor), 1.0f) * 2.5f;

Yes, seems more complicated than it deserves.

@nrupsis: This works quite well. I only see problems in very specific settings, mostly because "Simple Axes" (only) changes its width quite a lot as the "Line Width" is changed. If you change the resolution scale to 2.0, then change the Line Width to "Thick" or "Thin" you will see the text overlapping. This width change depends on U.pixelsize. Because all the offsets are multiplied by U.scale_factor later, this is as simple of a solution as I could find - and it is not perfect. Close enough? ``` case USER_MINI_AXIS_TYPE_MINIMAL: offset = U.rvisize * MIN2((U.pixelsize / U.scale_factor), 1.0f) * 2.5f; ``` Yes, seems more complicated than it deserves.
Nate Rupsis added 1 commit 2023-08-22 04:27:58 +02:00
Author
Member

@Harley oof, yeah I forgot about UI scaling. tried it out, and it looks good to me. Honestly anything non-overlapping will be an improvement. Appreciate your input!

@Harley oof, yeah I forgot about UI scaling. tried it out, and it looks good to me. Honestly anything non-overlapping will be an improvement. Appreciate your input!
Harley Acheson approved these changes 2023-08-23 21:23:15 +02:00
Member

@nrupsis - Honestly anything non-overlapping will be an improvement.

Yes, that combination of "Simple Axes" and "Thin lines" is so unlikely.

> @nrupsis - Honestly anything non-overlapping will be an improvement. Yes, that combination of "Simple Axes" and "Thin lines" is so unlikely.
Christoph Lendenfeld approved these changes 2023-08-24 11:48:30 +02:00
Christoph Lendenfeld left a comment
Member

lgtm

lgtm
@ -1497,3 +1497,3 @@
/* just draw a little warning message in the top-right corner of the viewport
* to warn that autokeying is enabled */
static void drawAutoKeyWarning(TransInfo * /*t*/, ARegion *region)
static void drawAutoKeyWarning(TransInfo * /*t*/, const bContext *C, ARegion *region)

not for this PR but removing TransInfo would be a good cleanup

not for this PR but removing `TransInfo` would be a good cleanup
Nate Rupsis merged commit 2cb5f83940 into main 2023-08-24 15:25:52 +02:00
Nate Rupsis deleted branch 105565-global_auto_key_overlap 2023-08-24 15:25:54 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#111356
No description provided.