Fix #97049: Auto-keyframe Status Message Overlaps Navigation Gizmo #111356

Nate Rupsis · 2023-08-21T19:20:30+02:00

Nate Rupsis commented

2023-08-21 19:20:30 +02:00

Finishing developing / landing #105565

"Auto Keying On" display now respects users MINI_AXIS preferences (default, minimal, none), as well as the navigation (en)disable option. No more text overlapping.

Finishing developing / landing [#105565](https://projects.blender.org/blender/blender/pulls/105565) --- "Auto Keying On" display now respects users MINI_AXIS preferences (default, minimal, none), as well as the navigation (en)disable option. No more text overlapping.

Nate Rupsis added 4 commits 2023-08-21 19:20:42 +02:00

source applied 3419ce131d

Merge branch 'main' into 105565-global_auto_key_overlap 594dcb3569

check to see if navigation is (dis/ed)abled and pad accordingly 0f3dc5577a

slight cleanup 2344bc8297

Nate Rupsis requested review from Sybren A. Stüvel 2023-08-21 19:20:52 +02:00

Nate Rupsis requested review from Harley Acheson 2023-08-21 19:21:02 +02:00

Nate Rupsis requested review from Christoph Lendenfeld 2023-08-21 19:21:19 +02:00

Nate Rupsis added the

Module

Animation & Rigging

label 2023-08-21 19:21:28 +02:00

Nate Rupsis added this to the Animation & Rigging project 2023-08-21 19:21:34 +02:00

Harley Acheson commented

2023-08-21 23:48:54 +02:00

@nrupsis:

This works quite well. I only see problems in very specific settings, mostly because "Simple Axes" (only) changes its width quite a lot as the "Line Width" is changed. If you change the resolution scale to 2.0, then change the Line Width to "Thick" or "Thin" you will see the text overlapping.

This width change depends on U.pixelsize. Because all the offsets are multiplied by U.scale_factor later, this is as simple of a solution as I could find - and it is not perfect. Close enough?

      case USER_MINI_AXIS_TYPE_MINIMAL:
        offset = U.rvisize * MIN2((U.pixelsize / U.scale_factor), 1.0f) * 2.5f;

Yes, seems more complicated than it deserves.

@nrupsis: This works quite well. I only see problems in very specific settings, mostly because "Simple Axes" (only) changes its width quite a lot as the "Line Width" is changed. If you change the resolution scale to 2.0, then change the Line Width to "Thick" or "Thin" you will see the text overlapping. This width change depends on U.pixelsize. Because all the offsets are multiplied by U.scale_factor later, this is as simple of a solution as I could find - and it is not perfect. Close enough? ``` case USER_MINI_AXIS_TYPE_MINIMAL: offset = U.rvisize * MIN2((U.pixelsize / U.scale_factor), 1.0f) * 2.5f; ``` Yes, seems more complicated than it deserves.

Nate Rupsis added 1 commit 2023-08-22 04:27:58 +02:00

adding in scale factor for people who use super UI scale f81a45a3e6

Nate Rupsis commented

2023-08-22 04:29:17 +02:00

@Harley oof, yeah I forgot about UI scaling. tried it out, and it looks good to me. Honestly anything non-overlapping will be an improvement. Appreciate your input!

Harley Acheson approved these changes 2023-08-23 21:23:15 +02:00

Harley Acheson commented

2023-08-23 21:35:16 +02:00

@nrupsis - Honestly anything non-overlapping will be an improvement.

Yes, that combination of "Simple Axes" and "Thin lines" is so unlikely.

> @nrupsis - Honestly anything non-overlapping will be an improvement. Yes, that combination of "Simple Axes" and "Thin lines" is so unlikely.

Christoph Lendenfeld approved these changes 2023-08-24 11:48:30 +02:00

Christoph Lendenfeld left a comment

lgtm

source/blender/editors/transform/transform.cc

						
				@ -1497,3 +1497,3 @@

				/* just draw a little warning message in the top-right corner of the viewport

				 * to warn that autokeying is enabled */

				static void drawAutoKeyWarning(TransInfo * /*t*/, ARegion *region)

				static void drawAutoKeyWarning(TransInfo * /*t*/, const bContext *C, ARegion *region)