Anim: remove unused GRAPH_MT_channel_context_menu #111384

Merged
Philipp Oeser merged 2 commits from lichtwerk/blender:remove_unused_GRAPH_MT_channel_context_menu into main 2023-09-27 09:29:53 +02:00
Member

Noticed GRAPH_MT_channel_context_menu is unused (since
DOPESHEET_MT_channel_context_menu is used in both Dopesheet & Graph/
Drivers Editor).

This patch removes GRAPH_MT_channel_context_menu but adds the entries
which were in that menu (but not in DOPESHEET_MT_channel_context_menu)
back to the later.

Namely:

  • Hide Selected Curves
  • Hide Unselected Curves
  • Reveal Curves
  • (Delete Invalid Drivers -- if in Drivers Editor)
Noticed GRAPH_MT_channel_context_menu is unused (since DOPESHEET_MT_channel_context_menu is used in both Dopesheet & Graph/ Drivers Editor). This patch removes GRAPH_MT_channel_context_menu but adds the entries which were in that menu (but not in DOPESHEET_MT_channel_context_menu) back to the later. Namely: - Hide Selected Curves - Hide Unselected Curves - Reveal Curves - (Delete Invalid Drivers -- if in Drivers Editor)
Philipp Oeser added 1 commit 2023-08-22 14:38:34 +02:00
78fb865698 Anim: remove unused GRAPH_MT_channel_context_menu
Noticed GRAPH_MT_channel_context_menu is unused (since
DOPESHEET_MT_channel_context_menu is used in both Dopesheet & Graph/
Drivers Editor).

This patch removes GRAPH_MT_channel_context_menu but adds the entries
which were in that menu (but not in DOPESHEET_MT_channel_context_menu)
back to the later.

Namely:
- Hide Selected Curves
- Hide Unselected Curves
- Reveal Curves
- (Delete Invalid Drivers -- if in Drivers Editor)
Philipp Oeser requested review from Brad Clark 2023-08-22 14:38:43 +02:00
Philipp Oeser requested review from Sybren A. Stüvel 2023-08-22 14:38:49 +02:00
Philipp Oeser requested review from Christoph Lendenfeld 2023-08-22 14:38:56 +02:00
Philipp Oeser added this to the Animation & Rigging project 2023-08-22 14:39:02 +02:00
Philipp Oeser added the
Interest
User Interface
label 2023-08-22 14:39:15 +02:00
Christoph Lendenfeld approved these changes 2023-08-24 11:02:02 +02:00
Christoph Lendenfeld left a comment
Member

lgtm
while I am not sure if sharing a context menu between the Dope Sheet and the Graph Editor is a good idea, this PR improves the current situation ;)

lgtm while I am not sure if sharing a context menu between the Dope Sheet and the Graph Editor is a good idea, this PR improves the current situation ;)
Sybren A. Stüvel approved these changes 2023-09-26 14:22:03 +02:00
Sybren A. Stüvel left a comment
Member

I agree with @ChrisLend , and given that the dopesheet menu already has if is_graph_editor: in there I think this change is definitely for the better. Thanks!

I agree with @ChrisLend , and given that the dopesheet menu already has `if is_graph_editor:` in there I think this change is definitely for the better. Thanks!
Philipp Oeser added 1 commit 2023-09-27 09:24:50 +02:00
Philipp Oeser merged commit e781a3bfdb into main 2023-09-27 09:29:53 +02:00
Philipp Oeser deleted branch remove_unused_GRAPH_MT_channel_context_menu 2023-09-27 09:29:54 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser Project (Legacy)
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#111384
No description provided.