Fix #110908: Crash when scrubbing timeline with sim node #111429
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#111429
Loading…
Reference in New Issue
No description provided.
Delete Branch "vitorboschi/blender:fix/geonodes_cache_assert"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The caching code was trying to insert cached frames in the wrong order,
making it hit an assert and crash.
Fix crash when scrubbing timeline with sim nodeto Fix #110908: Crash when scrubbing timeline with sim node0c1d605d3e
to6e40aa15e4
6e40aa15e4
to58b409d86e
Thanks, just a couple small comments
@ -133,0 +130,4 @@
const int64_t i = find_state_at_frame(states_at_frames_, frame);
if (i == -1) {
/* either we have an empty container, or the last frame < than the requested frame
Comment style (https://wiki.blender.org/wiki/Style_Guide/C_Cpp#Comments):
**
for comments inside of functionsShould be fixed now
@ -140,3 +150,1 @@
states_at_frames_.last()->frame = frame;
states_at_frames_.last()->state.owner_ = this;
return states_at_frames_.last()->state;
/** no cached frame found. Need to insert it just before #i to keep ordering */
#i
->@blender-bot build
58b409d86e
to2cccc3ef9b
2cccc3ef9b
to2e2a01006d
In the future, could you use regular non-force pushing when updating a PR branch, i.e. new commit rather than rebase? it makes it hard to see what you've changed compared to last time, and the PRs are squashed when they're committed anyway. Thanks.
@blender-bot build
@blender-bot build
@HooglyBoogly I see the Cycles tests are all failing in the buildbot. Is that some known issue? I find it hard to believe this patch would make (all of) those fail.
Sometimes tests fail on the buildbot briefly and are fixed. You can usually fix that for a branch by merging main. Sometimes the test files have been updated too, which can cause failures when the branch is based on an outdated version of main.
Thanks. I have now updated the PR. Is anyone able to request a build from the bot, or just Blender devs?
Insertion logic looks fine, just some cleanup for comments needed.
@ -133,0 +131,4 @@
const int64_t i = find_state_at_frame(states_at_frames_, frame);
if (i == -1) {
/* Either we have an empty container, or the last frame < than the requested frame
in both cases we can just append a new state at the end. */
Add a
*
in front of comment lines.Checkout
From your project repository, check out a new branch and test the changes.