Wireframe color option for all shading modes #111502

Gilberto Rodrigues · 2023-08-25T04:39:24+02:00

2023-08-25 04:39:24 +02:00

Enables three options of wireframe color for all shading modes: theme color, object color and random color.
Previously this was exclusive to the wireframe shading mode.

Enables three options of wireframe color for all shading modes: theme color, object color and random color. Previously this was exclusive to the wireframe shading mode.

Screenshot 2023-08-24 233815.png

489 KiB

Screenshot 2023-08-24 233328.png

27 KiB

👍 2

Gilberto Rodrigues added 1 commit 2023-08-25 04:39:39 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

4e0e59d1dc Colored wires option for all shading modes

Gilberto Rodrigues referenced this pull request

2023-08-25 04:44:45 +02:00

Refactor/Rewrite overlay wire colors #110097

Ray molenkamp commented

2023-08-25 06:11:40 +02:00

@blender-bot package

Blender Bot commented

2023-08-25 06:11:43 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR111502) when ready.

Julien Kaspar approved these changes 2023-08-25 11:07:11 +02:00

Julien Kaspar left a comment

Works as expected 👍

❤️ 1

Gilberto Rodrigues requested review from Jeroen Bakker 2023-08-25 11:09:02 +02:00

Gilberto Rodrigues requested review from Pablo Vazquez 2023-08-25 11:09:37 +02:00

Jeroen Bakker reviewed 2023-08-25 15:20:24 +02:00

Jeroen Bakker left a comment

Just a small tweak. Will do some platform checks on monday.

👍 1

scripts/startup/bl_ui/space_view3d.py

						
				@ -6316,4 +6316,4 @@

				    bl_parent_id = 'VIEW3D_PT_shading'

				    @classmethod

				    def poll(cls, context):

Jeroen Bakker commented

2023-08-25 15:16:45 +02:00

poll function can be removed as it is always true

Gilberto.R marked this conversation as resolved

Gilberto Rodrigues added 1 commit 2023-08-26 04:27:05 +02:00

f8c4b885c0 Remove poll()

Jeroen Bakker commented

2023-08-28 08:31:53 +02:00

Thanks,

I tested the patch and the only feedback I have is that it is unclear to the user that this setting is connected to the display wireframe option of the overlay pop-over. Just to give a hint I would de-activate (draw grey) the Wire Color option when the display wireframe is turned off, to give an indication to the user that changing this setting doesn't reflect directly to the user.
I would still display the option always for discoverability.

Thanks, I tested the patch and the only feedback I have is that it is unclear to the user that this setting is connected to the display wireframe option of the overlay pop-over. Just to give a hint I would de-activate (draw grey) the `Wire Color` option when the display wireframe is turned off, to give an indication to the user that changing this setting doesn't reflect directly to the user. I would still display the option always for discoverability.

Jeroen Bakker added this to the EEVEE & Viewport project 2023-08-28 08:32:58 +02:00

Jeroen Bakker added this to the 4.0 milestone 2023-08-28 08:33:04 +02:00

Gilberto Rodrigues commented

2023-08-28 10:03:55 +02:00

@Jeroen-Bakker I don't think it should be grayed out, because even if the wireframe toggle in the overlays panel is 'off', there can be objects with their viewport display set to "display as wireframe" in their object properties, or display as solid + wireframe(the wireframe toggle from the object's viewport display).