Geometry Nodes: Rename Blur Attribute to a Blur Field #111542

Closed

Iliya Katushenock wants to merge 3 commits from mod_moder:tmp_rename_blur_attribute into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Iliya Katushenock commented

2023-08-26 00:26:31 +02:00

Member

Similar to a Evaluate at Index or Evaluate on Domain, this is a field-base node, and should be moved/renamed to consistency with other field-base nodes.
Python an identifier not change, versioning not required.

Similar to a `Evaluate at Index` or `Evaluate on Domain`, this is a field-base node, and should be moved/renamed to consistency with other field-base nodes. Python an identifier not change, versioning not required. ![image](/attachments/a59ffbcb-7c48-44cd-8716-9a90458f5496) ![image](/attachments/c68dc5d6-85a3-496b-b141-102636c7ad61)

32 KiB

59 KiB

Iliya Katushenock added the

label 2023-08-26 00:26:31 +02:00

Iliya Katushenock added 1 commit 2023-08-26 00:26:42 +02:00

262673f277 init

Iliya Katushenock added this to the Nodes & Physics project 2023-08-26 00:26:48 +02:00

Iliya Katushenock added 1 commit 2023-08-26 00:36:09 +02:00

3639048e93 progress

Ludvik Koutny commented

2023-08-27 13:09:20 +02:00

Contributor

As a user, it was already difficult for me to find the node as I was looking for something like "Smooth Attribute". "Blur Attribute" is still somewhat okay, but "Evaluate for Blur" will be so cryptic most average users will be confused. Ideally, the node names should be so straightforward users never need to open some external documentation to figure out what they do. This change goes in opposite direction unfortunately.

As a user, it was already difficult for me to find the node as I was looking for something like "Smooth Attribute". "Blur Attribute" is still somewhat okay, but "Evaluate for Blur" will be so cryptic most average users will be confused. Ideally, the node names should be so straightforward users never need to open some external documentation to figure out what they do. This change goes in opposite direction unfortunately.

Hadrien commented

2023-08-27 13:54:53 +02:00

First-time contributor

I'm exceptionally taking the liberty to comment on a PR, because it seems a little ill-advised. I understand we're trying to be consistent with naming, and the proposed name is technically correct, but that's clearly a name pretty much no one will understand. If what you're trying to do is communicate that the node operates on a field instead of "an attribute", then perhaps "blur field" would work, or simply "blur", or even "blur value" (similar to "random value").

I'm exceptionally taking the liberty to comment on a PR, because it seems a little ill-advised. I understand we're trying to be consistent with naming, and the proposed name is technically correct, but that's clearly a name pretty much no one will understand. If what you're trying to do is communicate that the node operates on a field instead of "an attribute", then perhaps "blur field" would work, or simply "blur", or even "blur value" (similar to "random value").

Jakub Jaszewski commented

2023-08-28 12:08:22 +02:00

First-time contributor

I also think that this sounds weird. I think that there is no harm in having naming that is sometimes more loose, but is easier to understand even if this breaks some abstract naming rules.
With more and more rigid naming convention we are closer to the point of diminishing returns. UI as name implies must serve users first.

I also think that this sounds weird. I think that there is no harm in having naming that is sometimes more loose, but is easier to understand even if this breaks some abstract naming rules. With more and more rigid naming convention we are closer to the point of diminishing returns. UI as name implies must serve users first.

Iliya Katushenock added 1 commit 2023-08-29 17:21:57 +02:00

ac0967cd55 merge main, fix conflicts, rename

Iliya Katushenock changed title from ~~Geometry Nodes: Rename Blur Attribute to a Evaluate for Blur~~ to Geometry Nodes: Rename Blur Attribute to a Blur Field

2023-08-29 17:22:02 +02:00

Hans Goudey commented

2024-02-14 16:40:00 +01:00

Member

I don't think there's a strong enough reason to change this node's name. Generally using "Field" in the UI is a last resort, when there's no more accessible naming for the concepts.

I don't think there's a strong enough reason to change this node's name. Generally using "Field" in the UI is a last resort, when there's no more accessible naming for the concepts.

Hans Goudey closed this pull request

2024-02-14 16:40:03 +01:00

Iliya Katushenock deleted branch tmp_rename_blur_attribute

2024-02-14 17:12:31 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

5 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#111542

No description provided.