blender/blender
149
475
Fork 703
Code Issues 6.7k Pull Requests 891 Projects 18 Wiki Activity

Fix #95709: Improve pulldown menu corner rounding #111554

Merged
Harley Acheson merged 7 commits from lone_noel/blender:menu-corner-rounding into main 2023-11-24 23:55:50 +01:00
Conversation 5 Commits 7 Files Changed 2 +52 -8
Leon Schittek commented 2023-08-26 13:52:43 +02:00
Member
Copy Link

Round all corners of pulldown menus that are not attached to the parent
button.

This is a resubmission of https://archive.blender.org/developer/D11177

Comparison

First with the maximum "menu back" roundness of 1.0 to make it more obvious:

Alignment with Button Main Patch
one corner main_corner_10.png PR_corner_10.png
wider than button main_none_10.png PR_none_10.png
fully aligned (no change) main_both_10.png PR_both_10.png

And here with the default "menu back" roundness of 0.4

Alignment with Button Main Patch
one corner main_corner_04.png PR_corner_04.png
wider than button main_none_04.png PR_none_04.png
fully aligned (no change) main_both_04.png PR_both_04.png
Round all corners of pulldown menus that are not attached to the parent button. --- This is a resubmission of https://archive.blender.org/developer/D11177 #### Comparison First with the maximum "menu back" roundness of 1.0 to make it more obvious: |Alignment with Button|Main|Patch| |---|---|---| |one corner|![main_corner_10.png](/attachments/87156405-7435-4420-9b91-a0253c0be74c)|![PR_corner_10.png](/attachments/0746ddc1-58b0-4d15-96ff-097a3b6c2cfa)| |wider than button|![main_none_10.png](/attachments/7c705093-cca5-4a26-974b-a0a64e01276c)|![PR_none_10.png](/attachments/aabbef1e-fe13-4c68-b19e-9c17c6f2c52c)| |fully aligned (no change)|![main_both_10.png](/attachments/40e914d5-8397-4d98-8bdb-1344b6e2947f)|![PR_both_10.png](/attachments/66f5716e-f99a-40fe-9379-b17695c4796f)| And here with the default "menu back" roundness of 0.4 |Alignment with Button|Main|Patch| |---|---|---| |one corner|![main_corner_04.png](/attachments/54d902d9-fa5b-450d-b316-f725a8e74e29)|![PR_corner_04.png](/attachments/49d08843-83c5-4b9a-9a65-795f4ced6a09)| |wider than button|![main_none_04.png](/attachments/a2318e3c-ff68-4c00-a809-fb3a1a12f111)|![PR_none_04.png](/attachments/2b41c234-bc23-42a0-a2c4-86922787c641)| |fully aligned (no change)|![main_both_04.png](/attachments/51c24479-5cd0-4934-b844-6c104b226efd)|![PR_both_04.png](/attachments/a68506fe-0305-4552-b4bc-274ee3925088)|
main_both_04.png
11 KiB
PR_none_04.png
104 KiB
main_none_04.png
104 KiB
main_corner_04.png
24 KiB
PR_both_04.png
11 KiB
main_both_10.png
11 KiB
PR_corner_04.png
24 KiB
main_none_10.png
104 KiB
PR_both_10.png
11 KiB
PR_corner_10.png
24 KiB
main_corner_10.png
24 KiB
PR_none_10.png
104 KiB
👍 6 ❤️ 4
Leon Schittek added 1 commit 2023-08-26 13:52:58 +02:00 
Round all corners of pulldown menus that are not attached to the parent
button.
Leon Schittek added the
Module
User Interface
 label 2023-08-26 13:53:14 +02:00
Pablo Vazquez requested review from Pablo Vazquez 2023-08-30 18:04:56 +02:00
Pablo Vazquez approved these changes 2023-08-30 18:06:16 +02:00
Pablo Vazquez left a comment
Member
Copy Link

Yay! This one has been bothering me for a while but never thought of making a task.

Thanks! +1 (from the UI point of view, can't review code itself)

Yay! This one has been bothering me for a while but never thought of making a task. Thanks! +1 (from the UI point of view, can't review code itself)
Pablo Vazquez added this to the User Interface project 2023-08-30 18:51:21 +02:00
Harley Acheson commented 2023-08-30 21:34:46 +02:00
Member
Copy Link

Love this. I haven't yet tested this patch but will do soon. So a couple dumb questions in the mean time...

I had some suspicion that the wonky top-right corner was related to the drawing of menu shadows. As in the shadow would look funny if the top-right corner was not squared off. I know some of your captures are showing them with some shadow, but it would be nice to confirm it looks okay when those things are made larger.

Do you know the reason for the differing corner radiuses top to bottom in your examples like this:

image

I realize it is not changing with this patch, just never noticed that before.

Love this. I haven't yet tested this patch but will do soon. So a couple dumb questions in the mean time... I had some suspicion that the wonky top-right corner was related to the drawing of menu shadows. As in the shadow would look funny if the top-right corner was not squared off. I know some of your captures are showing them with some shadow, but it would be nice to confirm it looks okay when those things are made larger. Do you know the reason for the differing corner radiuses top to bottom in your examples like this: ![image](/attachments/65ea29ff-4082-4d0c-a344-dd01ea55f346) I realize it is not changing with this patch, just never noticed that before.
image.png
12 KiB
Pablo Vazquez commented 2023-08-30 22:34:11 +02:00
Member
Copy Link

Do you know the reason for the differing corner radiuses top to bottom in your examples like this:

image

Haven't tested the patch, but they are two different corner radius settings. One is Menu and the actual dropdown is Menu Back.

> Do you know the reason for the differing corner radiuses top to bottom in your examples like this: > > ![image](/attachments/65ea29ff-4082-4d0c-a344-dd01ea55f346) Haven't tested the patch, but they are two different corner radius settings. One is `Menu` and the actual dropdown is `Menu Back`.
Harley Acheson commented 2023-08-30 23:54:44 +02:00
Member
Copy Link

One is Menu and the actual dropdown is Menu Back.

Ah, makes sense. So this is an intentional difference. No worries then.

> One is `Menu` and the actual dropdown is `Menu Back`. Ah, makes sense. So this is an intentional difference. No worries then.
Leon Schittek commented 2023-09-01 16:54:49 +02:00
Author
Member
Copy Link

I had some suspicion that the wonky top-right corner was related to the drawing of menu shadows. As in the shadow would look funny if the top-right corner was not squared off. I know some of your captures are showing them with some shadow, but it would be nice to confirm it looks okay when those things are made larger.

Yeah, a large corner roundness with a small shadow width looks quite bad - though you can get the same issue with reverse/upside-down pulldowns in main (see below).

I made a separate PR to help with that: #111794

Large rounded corner (this PR) Reverse Pulldown (main)
shadow-issue_pr.png shadow-issue_main.png
> I had some suspicion that the wonky top-right corner was related to the drawing of menu shadows. As in the shadow would look funny if the top-right corner was not squared off. I know some of your captures are showing them with some shadow, but it would be nice to confirm it looks okay when those things are made larger. Yeah, a large corner roundness with a small shadow width looks quite bad - though you can get the same issue with reverse/upside-down pulldowns in main (see below). I made a separate PR to help with that: #111794 |Large rounded corner (this PR)|Reverse Pulldown (main)| |---|---| |![shadow-issue_pr.png](/attachments/56721bac-7c33-4379-8984-fa9f3e00e311)|![shadow-issue_main.png](/attachments/da873522-5f29-4c5f-9ef9-3bdb90ffec5f)|
shadow-issue_pr.png
96 KiB
shadow-issue_main.png
99 KiB
❤️ 1
Leon Schittek added 3 commits 2023-09-09 18:44:01 +02:00
Leon Schittek added 1 commit 2023-11-10 13:23:27 +01:00
Harley Acheson added 2 commits 2023-11-24 23:22:39 +01:00
Only comment changes.
All checks were successful
buildbot/vexp-code-patch-coordinator Build done.
Details
b36422e374
Harley Acheson commented 2023-11-24 23:23:53 +01:00
Member
Copy Link

@blender-bot build

@blender-bot build
Harley Acheson requested review from Harley Acheson 2023-11-24 23:24:22 +01:00
Harley Acheson approved these changes 2023-11-24 23:54:41 +01:00
Harley Acheson left a comment
Member
Copy Link

Awesome. Thanks!

Awesome. Thanks!
❤️ 1
Harley Acheson merged commit 42ddc13033 into main 2023-11-24 23:55:50 +01:00
Leon Schittek deleted branch menu-corner-rounding 2023-11-25 10:09:41 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Pablo Vazquez
Harley Acheson
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
User Interface
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#111554
No description provided.
Delete Branch "lone_noel/blender:menu-corner-rounding"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?