Fix #111613: Gesture selection does not deselect when elements hidden #111692

Pratik Borhade · 2023-08-30T13:22:25+02:00

Pratik Borhade commented

2023-08-30 13:22:25 +02:00

When objects/collections are hidden, BASE_SELECTED flag is cleared in
BKE_base_eval_flags. When deselecting in viewport, this flag is
considered, otherwise selection is skipped. If nothing is changed during
select/box/lasso select, notifiers are not sent to other regions. Due to
above reasons, selection of hidden object is skipped.
To fix this, send notifiers to outliner whenever operation is executed.

Would it affect the performence in large files? I'm not sure. In that case we can think
of alternative solution.

When objects/collections are hidden, `BASE_SELECTED` flag is cleared in `BKE_base_eval_flags`. When deselecting in viewport, this flag is considered, otherwise selection is skipped. If nothing is changed during select/box/lasso select, notifiers are not sent to other regions. Due to above reasons, selection of hidden object is skipped. To fix this, send notifiers to outliner whenever operation is executed. Would it affect the performence in large files? I'm not sure. In that case we can think of alternative solution.

Pratik Borhade added 1 commit 2023-08-30 13:22:36 +02:00

9bd3d4fac9 Fix #111613 : Gesture selection does not deselect when elements hidden

When objects/collections are hidden, `BASE_SELECTED` flag is cleared in
`BKE_base_eval_flags`. When deselecting in viewport, this flag is
considered, otherwise selection is skipped. If nothing is changed during
select/box/lasso select, notifiers are not sent to other regions. Due to
above reasons, selection of hidden object is skipped.
To fix this, send notifiers to outliner whenever operation is executed.

Would it affect the performace? I'm not sure. In that case we can think
of alternative solution.

Pratik Borhade requested review from Julien Kaspar 2023-08-30 13:23:35 +02:00

Pratik Borhade added the

Module

User Interface

label 2023-08-30 13:23:43 +02:00

Pratik Borhade referenced this pull request

2023-08-30 13:24:39 +02:00

Gesture selection does not deselect on nothing if collection is hidden #111613

Pratik Borhade commented

2023-08-30 13:25:54 +02:00

When deselecting in viewport, this flag is considered

One reference commit: 98bb22a207
I can understand the importance of BASE_SELECTED. Without this if condition, undo steps will be created on every operator call.

> When deselecting in viewport, this flag is considered One reference commit: 98bb22a207037c32ab3dfa3fb3c0df343c611dfb I can understand the importance of `BASE_SELECTED`. Without this `if` condition, undo steps will be created on every operator call.

Julien Kaspar commented

2023-08-30 14:29:13 +02:00

It works fine with collections with this patch.
But hidden objects are still not deselected in the outliner when using box/lasso selection on empty space. This is still inconsistent with using click selection in empty space.

It works fine with collections with this patch. But hidden objects are still not deselected in the outliner when using box/lasso selection on empty space. This is still inconsistent with using click selection in empty space.

👍 1

Pratik Borhade added 1 commit 2023-08-31 12:28:46 +02:00

94f785cfa7 Cleanup: Remove duplicate

Pratik Borhade commented

2023-08-31 13:18:11 +02:00

@JulienKaspar , thanks. AFAICS, objects are not deselected by box/lasso gestures when collection is hidden but not the object. Is this what you're observing after applying the PR?

@JulienKaspar , thanks. AFAICS, objects are not deselected by box/lasso gestures [when collection is hidden but not the object](/attachments/6900159a-44ea-4807-b53e-af105ef8a978). Is this what you're observing after applying the PR?

image.png

13 KiB

Julien Kaspar commented

2023-08-31 14:19:24 +02:00

@PratikPB2123 Correct.

Pratik Borhade commented

2023-09-01 12:15:22 +02:00

This can be fixed either by removing BASE_SELECTED flags for child objects of collection
or by removing if(BASE_SELECTABLE(v3d, base)) condition from object_deselect_all_visible function definition.

I'm not sure about consequences of these suggested changes.
@ideasman42 , any idea?

Edit:

Why objects are not deselecting when only collection is hidden:

Because object still has `BASE_SELECTED` flag set. If object is not visible and `BASE_SELECTED` flag is set then `BASE_SELECTED` flag is not cleared in `object_deselect_all_visible`

During outline redraw, tree element will remain selected because BASE_SELECTED is still there, see: outliner_select_sync_from_object

This can be fixed either by removing `BASE_SELECTED` flags for child objects of collection or by removing `if(BASE_SELECTABLE(v3d, base))` condition from `object_deselect_all_visible` function definition. I'm not sure about consequences of these suggested changes. @ideasman42 , any idea? - - - Edit: <details> <summary> Why objects are not deselecting when only collection is hidden: </summary> Because object still has `BASE_SELECTED` flag set. If object is not visible and `BASE_SELECTED` flag is set then `BASE_SELECTED` flag is not cleared in `object_deselect_all_visible` During outline redraw, tree element will remain selected because `BASE_SELECTED` is still there, see: `outliner_select_sync_from_object` </details>

This pull request has changes conflicting with the target branch.

source/blender/editors/space_view3d/view3d_select.cc

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u 111613-fix-click-deselect:PratikPB2123-111613-fix-click-deselect

git checkout PratikPB2123-111613-fix-click-deselect

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #111613: Gesture selection does not deselect when elements hidden #111692

Checkout