Fix: socket hidden in the link drag operator for group input nodes #111707

Lukas Tönne · 2023-08-30T18:41:30+02:00

Lukas Tönne commented

2023-08-30 18:41:30 +02:00

Two issues fixed here:

Mixup of "in" and "out" flags.
Missing node tree update tag to ensure group input nodes all have
the new socket so it can be hidden.

Two issues fixed here: 1. Mixup of "in" and "out" flags. 2. Missing node tree update tag to ensure group input nodes all have the new socket so it can be hidden.

Lukas Tönne added 1 commit 2023-08-30 18:41:39 +02:00

6f1fa4ae16 Fix socket hiding in the link drag operator for group input nodes.

Two issues fixed here:
1. Mixup of "in" and "out" flags.
2. Missing node tree update tag to ensure group input nodes all have
   the new socket so it can be hidden.

Lukas Tönne changed title from ~~Fix socket hiding in the link drag operator for group input nodes.~~ to Fix socket hiding in the link drag operator for group input nodes

2023-08-30 18:41:57 +02:00

Lukas Tönne requested review from Hans Goudey 2023-08-30 18:42:03 +02:00

Lukas Tönne added this to the Nodes & Physics project 2023-08-30 18:42:08 +02:00

Hans Goudey approved these changes 2023-08-30 18:43:53 +02:00

Hans Goudey changed title from ~~Fix socket hiding in the link drag operator for group input nodes~~ to Fix: socket hidden in the link drag operator for group input nodes

2023-08-30 18:44:21 +02:00

Lukas Tönne reviewed 2023-08-30 18:46:38 +02:00

source/blender/editors/space_node/link_drag_search.cc

						
				@ -98,2 +94,3 @@

				      flag,

				      NODE_INTERFACE_SOCKET_INPUT,

				      nullptr);

				  BKE_ntree_update_tag_interface(&params.node_tree);

Lukas Tönne commented

2023-08-30 18:46:38 +02:00

This is a bit annoying:
Previously operators like this could rely on API functions to tag the node tree for updates internally. Now this is not so easy because the functions don't have direct access to the node tree, most of them are members of the bNodeTreeInterface nested in bNodeTree.

Rather than moving everything to bNodeTree i would suggest adding flags in bNodeTreeInterface as well to keep these structs a separate. This would basically be just the NTREE_CHANGED_INTERFACE flag. The NodeTreeMainUpdater can simply check flags of the ntree->tree_interface in addition to ntree flags.

This is a bit annoying: Previously operators like this could rely on API functions to tag the node tree for updates internally. Now this is not so easy because the functions don't have direct access to the node tree, most of them are members of the `bNodeTreeInterface` nested in `bNodeTree`. Rather than moving everything to `bNodeTree` i would suggest adding flags in `bNodeTreeInterface` as well to keep these structs a separate. This would basically be just the `NTREE_CHANGED_INTERFACE` flag. The `NodeTreeMainUpdater` can simply check flags of the `ntree->tree_interface` in addition to `ntree` flags.

👍 1

Lukas Tönne commented

2023-08-31 14:07:25 +02:00

This would be fixed by #111741