Fix #111162: Overlay drawing issues due to shared library using fastmath #111708
Cycles oneAPI kernel library was compiled using -ffast-math. The current
version of Clang makes it link to crtfastmath.o in that case, bringing a
static constructor that does set the FTZ/DAZ bits in MXCSR for the whole
program, leading to unwanted behavior with other components.
Instead of -ffast-math, we switch to a safer subset of compile flags.
Package build started. Download here when ready.
On a code side the change looks good to me.
From own experience such change might cause some performance impact if some flag is missed. I don't currently have a quick access to a machine with oneAPI so can not verify the performance.
So, if you feel comfortable with the change from the render time perspective just go ahead and commit :)
Thanks! I've checked the performance of this set with current ocloc and it's basically equal on my machine, within +-0.5%.
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?