Fix #111713: Nodes crash when overriding due to item.parent nullptr #111755

Lukas Tönne · 2023-08-31T18:14:26+02:00

Lukas Tönne commented

2023-08-31 18:14:26 +02:00

Library overrides crashed with on trying to access the interface root panel. The root panel should not be exposed through RNA, but also accessing its position property should be allowed.

Several fixes here:

Fix position property getter when the item has no parent panel (i.e. the root panel).
Avoid infinite loops in the greedy override comparison: exclude the loopback parent property.
Don't return the root panel via the parent property in the first place, just return nullptr.

Library overrides crashed with on trying to access the interface root panel. The root panel should not be exposed through RNA, but also accessing its `position` property should be allowed. Several fixes here: - Fix `position` property getter when the item has no parent panel (i.e. the root panel). - Avoid infinite loops in the greedy override comparison: exclude the loopback `parent` property. - Don't return the root panel via the `parent` property in the first place, just return nullptr.

Lukas Tönne added 3 commits 2023-08-31 18:14:39 +02:00

3268f57f40 Gracefully handle getting index of the root panel.

Currently accessing "parent.position" of node interface items can crash
because the parent can be the root panel which does not have a parent
itself. Getting a root panel pointer should be prevent by RNA, but for
internal access it must be handled properly.

2bf9ccda9a Exclude 'parent' property of items from override comparison.

Comparing both "parent" and "ui_items" in overrides leads to loopback:
`item.parent.items[0].parent.items[0].parent. ...`.

ea3d11769f Return nullptr instead of the root panel for RNA "parent" property.

Root panel should not be exposed through RNA. Cases of crashing behavior
have been resolved, but it's confusing and should not be returned by
any RNA function.

Lukas Tönne added this to the Nodes & Physics project 2023-08-31 18:14:54 +02:00

Lukas Tönne requested review from Bastien Montagne 2023-08-31 18:15:11 +02:00

Lukas Tönne requested review from Jacques Lucke 2023-08-31 18:15:11 +02:00

Lukas Tönne changed title from ~~Fix 111713: Nodes crash when overriding due to item.parent nullptr~~ to Fix #111713: Nodes crash when overriding due to item.parent nullptr

2023-08-31 18:15:30 +02:00

Jacques Lucke approved these changes 2023-08-31 18:20:24 +02:00

Lukas Tönne merged commit 2a94a99605 into main

2023-08-31 18:53:04 +02:00

Lukas Tönne deleted branch fix-root-panel-rna-crash

2023-08-31 18:53:06 +02:00

Lukas Tönne referenced this issue from a commit

2023-08-31 18:53:09 +02:00

Fix #111713: Nodes crash when overriding due to item.parent nullptr

Lukas Tönne referenced this pull request

2023-09-01 11:09:39 +02:00

Fix #111713: Nodes crash when library overriding #111782