UI: Add canvas picker to paint modes in 3D Viewport #111756

Merged

Pablo Vazquez merged 7 commits from pablovazquez/blender:ui-viewport-canvas-selector into main

2023-09-06 16:21:19 +02:00

Pablo Vazquez commented

2023-08-31 19:11:57 +02:00

Member

Many editors (UV/Image, Nodes, Action) have their source selector
in the center of the header. This patch brings that concept to
the paint modes in the 3D Viewport.

Goals:

Consistency with other editors.
Easier access to see which canvas we're working on and quickly switch.
Allows working in full screen without Properties/Sidebar open.

Available canvas in each mode:

Weight Paint: Vertex Groups
Vertex Paint: Color Attributes
Texture Paint: Canvas (material, image)
Sculpt Paint: Canvas (material, image, color attribute)

Many editors (UV/Image, Nodes, Action) have their source selector in the center of the header. This patch brings that concept to the paint modes in the 3D Viewport. Goals: * Consistency with other editors. * Easier access to see which canvas we're working on and quickly switch. * Allows working in full screen without Properties/Sidebar open. Available canvas in each mode: * **Weight Paint**: Vertex Groups * **Vertex Paint**: Color Attributes * **Texture Paint**: Canvas (material, image) * **Sculpt Paint**: Canvas (material, image, color attribute) <video src="/attachments/c3cf6c6f-47f9-4e5d-8b9b-252c21b6c752" title="paint_canvas_selector.mp4" controls></video>

paint_canvas_selector.mp4

1.6 MiB

Pablo Vazquez added the

Sculpt, Paint & Texture

labels 2023-08-31 19:11:57 +02:00

Pablo Vazquez added 1 commit 2023-08-31 19:12:06 +02:00

1821986e03 UI: Add canvas picker to paint modes in 3D Viewport

Many editors (UV/Image, Nodes, Action) have their source selector
in the center of the header. This patch brings that concept to
the paint modes in the 3D Viewport.

* Weight Paint: Vertex Groups
* Vertex Paint: Color Attributes
* Texture Paint: Canvas (material, image)
* Sculpt Paint: Canvas (material, image, color attribute)

Pablo Vazquez requested review from Julien Kaspar 2023-08-31 19:12:58 +02:00

Pablo Vazquez added this to the User Interface project 2023-08-31 19:20:27 +02:00

Julien Kaspar commented

2023-09-01 10:49:22 +02:00

Member

Tried it out again and overall works great. A couple of issues I noticed:

The canvas picker is not available in sculpt mode unless the experimental "Sculpt Texture Paint" preference is enabled.

The Texture slots are also always visible in the sidebar in every of the paint/sculpt modes. If "Sculpt Texture Paint" preference is enabled it even shows two panels.
We should probably remove the canvas picker from the sidebar entirely for UI consistency.

Tried it out again and overall works great. A couple of issues I noticed: The canvas picker is not available in sculpt mode unless the experimental "Sculpt Texture Paint" preference is enabled. The Texture slots are also always visible in the sidebar in every of the paint/sculpt modes. If "Sculpt Texture Paint" preference is enabled it even shows two panels. We should probably remove the canvas picker from the sidebar entirely for UI consistency. ![image](/attachments/5d119a01-0835-4cdd-bd8d-4fae61ab6ff1)

59 KiB

Pablo Vazquez added 1 commit 2023-09-01 12:31:28 +02:00

d08f11c589 Remove canvas selectors from sidebar

Pablo Vazquez commented

2023-09-01 12:34:55 +02:00

Author

Member

Thanks for reviewing!

The canvas picker is not available in sculpt mode unless the experimental "Sculpt Texture Paint" preference is enabled.

That hasn't changed with this patch. I just moved it places but in main you'll notice the Canvas menu in the tool settings bar also only shows up when the experimental setting is on. Removing the check for experimental should be a separate patch, as I'm not sure what exactly is affected by that setting.

The Texture slots are also always visible in the sidebar in every of the paint/sculpt modes.
We should probably remove the canvas picker from the sidebar entirely for UI consistency.

Fixed!

Thanks for reviewing! > The canvas picker is not available in sculpt mode unless the experimental "Sculpt Texture Paint" preference is enabled. That hasn't changed with this patch. I just moved it places but in `main` you'll notice the `Canvas` menu in the tool settings bar also only shows up when the experimental setting is on. Removing the check for experimental should be a separate patch, as I'm not sure what exactly is affected by that setting. > The Texture slots are also always visible in the sidebar in every of the paint/sculpt modes. > We should probably remove the canvas picker from the sidebar entirely for UI consistency. Fixed!

Pablo Vazquez added 2 commits 2023-09-04 12:07:42 +02:00

55d4b90ea3 Remove check for experimental Sculpt Paint

9c43f2365a Merge branch 'main' into ui-viewport-canvas-selector

Pablo Vazquez added 1 commit 2023-09-04 13:00:29 +02:00

ccb2a63fad Show icon in popover based on canvas_source

Pablo Vazquez added 1 commit 2023-09-04 14:11:32 +02:00

4b0d3c475b Address feedback

* In Sculpt mode, show color attributes picker grayed out if the active
  tool does not use canvas, or color mode is not Attribute.
* Bring back check for experimental.

Julien Kaspar commented

2023-09-04 14:41:00 +02:00

Member

I think with the current behavior this is all good 👍

There's one addition missing which should be added soon as a followup PR:
When a painting tool is active in sculpt mode, temporarily override the viewport shading color to "Attribute" and have the canvas picker not greyed out.
This is how it behaves in main atm with the experimental Sculpt Texture Paint preference enabled.

I think with the current behavior this is all good 👍 There's one addition missing which should be added soon as a followup PR: When a painting tool is active in sculpt mode, temporarily override the viewport shading color to "Attribute" and have the canvas picker not greyed out. This is how it behaves in `main` atm with the experimental Sculpt Texture Paint preference enabled.

Julien Kaspar approved these changes 2023-09-04 14:41:08 +02:00

Julien Kaspar commented

2023-09-04 15:47:38 +02:00

Member

Something that was pointed out that should be considered for the future:
Having the menu in the center of the header is not ideal if the popup is very long. It will cover the model in the 3D view.

For the current purposes this is ok. But this is unclear for future layered painting/sculpting which would use longer lists.
Perhaps this header popup can be kept minimal and small for switching and any future larger UI of layered textures and layered object data can be exposed in the properties editor.

Something that was pointed out that should be considered for the future: Having the menu in the center of the header is not ideal if the popup is very long. It will cover the model in the 3D view. For the current purposes this is ok. But this is unclear for future layered painting/sculpting which would use longer lists. Perhaps this header popup can be kept minimal and small for switching and any future larger UI of layered textures and layered object data can be exposed in the properties editor.

Pablo Vazquez requested review from Hans Goudey 2023-09-05 17:33:25 +02:00

Hans Goudey approved these changes 2023-09-06 14:16:33 +02:00

Hans Goudey left a comment

Member

This works well in my testing. There are some missing redraws in the header in sculpt mode when changing tools, but that can be considered separately IMO.

This works well in my testing. There are some missing redraws in the header in sculpt mode when changing tools, but that can be considered separately IMO.

Pablo Vazquez added 1 commit 2023-09-06 16:15:41 +02:00

691063c6c8 Merge branch 'main' into ui-viewport-canvas-selector

Pablo Vazquez merged commit 3b5df8a7ea into main

2023-09-06 16:21:19 +02:00

Pablo Vazquez referenced this issue from a commit

2023-09-06 16:21:19 +02:00

UI: Add canvas picker to paint modes in 3D Viewport

Pablo Vazquez deleted branch ui-viewport-canvas-selector

2023-09-06 16:21:21 +02:00

Stefan Werner referenced this issue from a commit

2023-09-07 15:02:40 +02:00

UI: Add canvas picker to paint modes in 3D Viewport

Nika Kutsniashvili commented

2023-09-11 20:57:46 +02:00

Contributor

Would be nice if Texture Slots duplicate was removed from Tool Settings in the texture paint mode. It's too long and takes too much space in already crowded horizontal bar.

Would be nice if Texture Slots duplicate was removed from Tool Settings in the texture paint mode. It's too long and takes too much space in already crowded horizontal bar.

Julien Kaspar commented

2023-09-12 10:11:03 +02:00

Member

Would be nice if Texture Slots duplicate was removed from Tool Settings in the texture paint mode. It's too long and takes too much space in already crowded horizontal bar.

That should be done now in main. Only the texture slots in the header remains.

> Would be nice if Texture Slots duplicate was removed from Tool Settings in the texture paint mode. It's too long and takes too much space in already crowded horizontal bar. That should be done now in main. Only the texture slots in the header remains.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#111756

No description provided.