UI: Slight reduction and centering of UI_BTYPE_SEPR_LINE #111764

Merged
Harley Acheson merged 2 commits from Harley/blender:MenuSep into main 2023-09-01 17:12:54 +02:00
Member

A small reduction in the vertical space used by the menu separating
rule. Also centers the line within its space. Looks more balanced when
used between titles and content.

This the line used between dropdown menus sections and between list titles/categories and their content below. It is currently a little wide and the line is one pixel lower than centered. This results in (what I see) as a clumsiness where the title looks to be higher than vertically centered and the line looks too low.

The following animated GIF contrasts before and after. The "tighter" one is what this PR proposes. The tighter one should make the titles look to be vertically centered in their row.

EditorMenu.gif

A side-by-side example showing the same thing. The right side should look a bit more vertically balanced around the title and the separator should seem to be in a nicer place:

image

A small reduction in the vertical space used by the menu separating rule. Also centers the line within its space. Looks more balanced when used between titles and content. This the line used between dropdown menus sections and between list titles/categories and their content below. It is currently a little wide and the line is one pixel lower than centered. This results in (what I see) as a clumsiness where the title looks to be higher than vertically centered and the line looks too low. The following animated GIF contrasts before and after. The "tighter" one is what this PR proposes. The tighter one should make the titles look to be vertically centered in their row. ![EditorMenu.gif](/attachments/012fbd98-4e0c-438a-aa88-3fc8b6903f60) A side-by-side example showing the same thing. The right side should look a bit more vertically balanced around the title and the separator should seem to be in a nicer place: ![image](/attachments/362512e8-8851-4051-82c3-ae0dbac35e71)
Harley Acheson added 1 commit 2023-09-01 00:20:16 +02:00
543910a7de UI: Slight reduction and centering of UI_BTYPE_SEPR_LINE
A small reduction in the vertical space used by the menu separating
rule. Also centers the line within its space. Looks more balanced when
used between titles and content.
Harley Acheson added this to the User Interface project 2023-09-01 00:20:29 +02:00
Harley Acheson requested review from Pablo Vazquez 2023-09-01 00:20:37 +02:00
Pablo Vazquez approved these changes 2023-09-01 01:30:53 +02:00
Pablo Vazquez left a comment
Member

nice one! thanks!

nice one! thanks!
Harley Acheson added 1 commit 2023-09-01 01:50:27 +02:00
buildbot/vexp-code-patch-coordinator Build done. Details
5a990ce6cf
Adding casts incase anything warns.
Author
Member

@blender-bot build

@blender-bot build
Harley Acheson merged commit 2dc1dcc43e into main 2023-09-01 17:12:54 +02:00
Harley Acheson deleted branch MenuSep 2023-09-01 17:12:56 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#111764
No description provided.