UI: Show Labels for BSDF "Distribution" and "Subsurface Method" #111766

Harley Acheson · 2023-09-01T01:21:52+02:00

Harley Acheson commented

2023-09-01 01:21:52 +02:00

Add labels to the BSDF options "Distribution" and "Subsurface Method",
since this type of enum list no longer shows titles since #109798.

All these items should have labels since we longer show the titles in this type of situation. With this PR it looks like this:

Add labels to the BSDF options "Distribution" and "Subsurface Method", since this type of enum list no longer shows titles since #109798. --- All these items should have labels since we longer show the titles in this type of situation. With this PR it looks like this: ![image](/attachments/28e10f9d-4c3a-4f57-abe1-2a1dd1981b6e)

image.png

50 KiB

Harley Acheson added 1 commit 2023-09-01 01:22:12 +02:00

aa9f503bdf UI: Show Labels for BSDF "Distribution" and "Subsurface Method"

Add labels to the BSDF options "Distribution" and "Subsurface Method",
since this type of enum list no longer shows titles since #109798.

Harley Acheson added this to the User Interface project 2023-09-01 01:22:25 +02:00

Harley Acheson requested review from Hans Goudey 2023-09-01 01:22:37 +02:00

Hans Goudey commented

2023-09-01 01:44:20 +02:00

Makes sense in the screenshot. But how does it look in the node editor?

Harley Acheson commented

2023-09-01 02:02:22 +02:00

Makes sense in the screenshot. But how does it look in the node editor?

Ewww.... With factory settings and default sizes it looks cut off...

Is there some way of fixing that?

> Makes sense in the screenshot. But how does it look in the node editor? Ewww.... With factory settings and default sizes it looks cut off... ![image](/attachments/4ebe4710-63ff-452a-afee-551d1efa7b5f) Is there some way of fixing that?

image.png

66 KiB

Hans Goudey commented

2023-09-01 02:25:28 +02:00

Hmm, how about checking the context (node editor vs properties) in the drawing callback? A bit weird to do that but not really wrong!

Harley Acheson commented

2023-09-01 17:29:23 +02:00

@HooglyBoogly - Hmm, how about checking the context (node editor vs properties) in the drawing callback? A bit weird to do that but not really wrong!

I didn't think of that. That does work, but then only solves the problem in one place. But maybe that is okay?

With #109798 we are assuming that we need the enum list title if we are clicking on an icon, but that we don't need it if we are showing text since we normally show those with labels. If I do this differently depending on context I get the following:

It shows that clicking on Subsurface Method on the Node itself does not show the title for that list. Nor will it in the Sidebar. However, it isn't needed in Properties since there is the label to the left.

Does this matter? If yes, then the next step is probably just adding a flag somewhere to force titles on?

> @HooglyBoogly - Hmm, how about checking the context (node editor vs properties) in the drawing callback? A bit weird to do that but not really wrong! I didn't think of that. That does work, but then only solves the problem in one place. But maybe that is okay? With #109798 we are assuming that we need the enum list **title** if we are clicking on an icon, but that we don't need it if we are showing text since we normally show those with labels. If I do this differently depending on context I get the following: ![image](/attachments/737640d5-dc49-46b4-92b5-0d9329070773) It shows that clicking on Subsurface Method on the Node itself does not show the title for that list. Nor will it in the Sidebar. However, it isn't needed in Properties since there is the label to the left. Does this matter? If yes, then the next step is probably just adding a flag somewhere to force titles on?

image.png

109 KiB

Harley Acheson added 1 commit 2023-09-01 17:31:45 +02:00

20d72605cb Use context to show the labels in Properties only.

Hadrien commented

2023-09-01 18:53:21 +02:00

First-time contributor

The value fields and their labels are consolidated in nodes -taking up all available width- but split in the material editor. Perhaps the dropdowns could behave the same? ->one wide dropdown, label left-aligned, item/value right-aligned. This would benefit a number of node dropdowns (principled hair, refraction, etc). Right now it looks like they take up a proportion of the total node width, not accounting for contents.

The situation could be made better for colors as well, their labels also get clipped (subsurface color most notably), but that's a different issue since we can't really overprint text on an arbitrary color. I guess these would have to be a fixed size, or something.

The value fields and their labels are consolidated in nodes -taking up all available width- but _split_ in the material editor. Perhaps the dropdowns could behave the same? ->one wide dropdown, label left-aligned, item/value right-aligned. This would benefit a number of node dropdowns (principled hair, refraction, etc). Right now it looks like they take up a proportion of the total node width, not accounting for contents. The situation could be made better for colors as well, their labels also get clipped (_subsurface color_ most notably), but that's a different issue since we can't really overprint text on an arbitrary color. I guess these would have to be a fixed size, or something.

Harley Acheson commented

2023-09-02 01:57:50 +02:00

I don't need to do this.

I can decide whether to show enum list titles based on the previous item in the layout. So show titles if there isn't a prior label. So far seems to work fine.

I don't need to do this. I can decide whether to show enum list titles based on the previous item in the layout. So show titles if there isn't a prior label. So far seems to work fine.

Harley Acheson closed this pull request

2023-09-02 01:57:51 +02:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

UI: Show Labels for BSDF "Distribution" and "Subsurface Method" #111766

Pull request closed