Fix #111017: Improvements to the drawing of Color Ramps #111903

Harley Acheson · 2023-09-03T22:38:01+02:00

Harley Acheson commented

2023-09-03 22:38:01 +02:00

Color Ramp widget with themed outline, handling of line width changes,
padding fixes, scaling fixes, etc.

Weekend time spend on the Color Ramp widget, based on research done with @lichtwerk. Current code has some issues, some shown below:

The outline around the ramp itself is always black and doesn't respect line width. This PR has it use Regular's outline color (respecting alpha) in line width.

This widget has left and right padding so that the handles can be used when at the edges. However this gap gets larger as the widget is scaled down. This PR keeps the same visual padding with scale changes.

The handles don't respect line width and the outline often leaves gaps. This PR has the various parts of the handles line up correctly and positioned and sized correctly with line width change.

The vertical dash indicator changes readability with scale changes. Since the dash lengths are always the same number of pixels they get too long as the widget is scaled down. This PR keeps a proportionally-correct dash length.

The handles currently disappear abruptly when below a size threshold. This PR uses changes to opacity and line width to fade them out nicer.

The contrast difference between active and non-active handles is increased a bit.

Following illustrates how it looks as line-width is changed. Note the outline color is purposely changed to gold for the capture to show contrast.

Color Ramp widget with themed outline, handling of line width changes, padding fixes, scaling fixes, etc. --- Weekend time spend on the Color Ramp widget, based on research done with @lichtwerk. Current code has some issues, some shown below: ![image](/attachments/8de6fffb-d605-4699-8488-f56561c19070) The outline around the ramp itself is always black and doesn't respect line width. This PR has it use Regular's outline color (respecting alpha) in line width. This widget has left and right padding so that the handles can be used when at the edges. However this gap gets larger as the widget is scaled down. This PR keeps the same visual padding with scale changes. The handles don't respect line width and the outline often leaves gaps. This PR has the various parts of the handles line up correctly and positioned and sized correctly with line width change. The vertical dash indicator changes readability with scale changes. Since the dash lengths are always the same number of pixels they get too long as the widget is scaled down. This PR keeps a proportionally-correct dash length. The handles currently disappear abruptly when below a size threshold. This PR uses changes to opacity and line width to fade them out nicer. The contrast difference between active and non-active handles is increased a bit. Following illustrates how it looks as line-width is changed. Note the outline color is purposely changed to gold for the capture to show contrast. ![ColorRampThickness.gif](/attachments/e1e85953-1461-47df-ba1f-fb7968ac09ae)

image.png

54 KiB

ColorRampThickness.gif

55 KiB

ColorRampThickness.gif

52 KiB

👍 6

Harley Acheson added 1 commit 2023-09-03 22:38:12 +02:00

77f7e5a6b2 UI: Improvements to the drawing of Color Ramps

Color Ramp widget with themed outline, handling of line width changes,
padding fixes, scaling fixes, etc.

Harley Acheson added this to the User Interface project 2023-09-03 22:38:46 +02:00

Harley Acheson requested review from Pablo Vazquez 2023-09-03 22:38:56 +02:00

Harley Acheson requested review from Philipp Oeser 2023-09-03 22:39:07 +02:00

Pablo Vazquez approved these changes 2023-09-03 23:34:20 +02:00

Pablo Vazquez left a comment

The definition of attention to detail you all in that thread :)

Thanks for the dedication.

The definition of attention to detail you all in that thread :) Thanks for the dedication.

Philipp Oeser referenced this pull request

2023-09-05 11:27:01 +02:00

Fix #111017: Gap between color square and frame of box in the color ramp #111168

Philipp Oeser commented

2023-09-05 16:25:12 +02:00

Just noting that this would fix #111017 (the commit message or title should probably mention this as well).

I am a bit torn on the increased size of the handles (since they now eat away a bit from the actual gradient -- which is now a bit harder to see) but trust you guys on this and overall it is a good improvement.

Just noting that this would fix #111017 (the commit message or title should probably mention this as well). I am a bit torn on the increased size of the handles (since they now eat away a bit from the actual gradient -- which is now a bit harder to see) but trust you guys on this and overall it is a good improvement.

Philipp Oeser approved these changes 2023-09-05 16:25:34 +02:00

Harley Acheson changed title from ~~UI: Improvements to the drawing of Color Ramps~~ to Fix #111017: Improvements to the drawing of Color Ramps

2023-09-05 19:24:35 +02:00

Harley Acheson commented

2023-09-05 20:13:32 +02:00

@lichtwerk -I am a bit torn on the increased size of the handles (since they now eat away a bit from the actual gradient -- which is now a bit harder to see)

This PR now keeps them the same size as current. I have updated the animated gif in the first comment.

> @lichtwerk -I am a bit torn on the increased size of the handles (since they now eat away a bit from the actual gradient -- which is now a bit harder to see) This PR now keeps them the same size as current. I have updated the animated gif in the first comment.

Harley Acheson added 2 commits 2023-09-05 20:14:58 +02:00

524be1fa7f Merge branch 'main' of projects.blender.org:blender/blender into ColorRamp

buildbot/vexp-code-patch-coordinator Build done. Details

a1a9f12082 Keep the handle sizes the same as current.

Harley Acheson commented

2023-09-05 20:18:51 +02:00

@blender-bot build

Harley Acheson merged commit 8a3766e241 into main

2023-09-06 00:00:47 +02:00

Harley Acheson deleted branch ColorRamp

2023-09-06 00:00:48 +02:00

Harley Acheson referenced this issue from a commit